Skip to content

Vite migration - #302

Merged
dankelleher merged 35 commits into
developfrom
vite-migration
Jul 21, 2025
Merged

Vite migration#302
dankelleher merged 35 commits into
developfrom
vite-migration

Conversation

@dankelleher

Copy link
Copy Markdown
Member

No description provided.

…sues - parking for now until anchor catches up with solana
impact nft update failure does not block unlock
The issue: After upgrading Anchor/Solana libraries, the mainnet report was failing with
"Invalid account discriminator" errors. This was because:

1. Marinade's on-chain state account is named "State" with discriminator [216, 146, 107, 94, 104, 75, 182, 177]
2. Anchor's declare_program\! renames it to "MarinadeState" to avoid conflicts with our "State"
3. This changes the expected discriminator, causing mismatches with on-chain accounts

The solution:
- Use UncheckedAccount for all marinade_state fields in instructions
- Created deserialize_marinade_state() utility that checks for the correct on-chain discriminator
- Added comprehensive comments explaining why this approach is necessary
- Maintained our State struct name for backward compatibility

This allows the program to work with existing on-chain Marinade accounts while avoiding
naming conflicts between the two programs.
- Upgrade from Rust 1.80.0 to 1.82.0 for latest stable features
- Add rustfmt and clippy components to ensure they're available in CI
- Fixes lint-program job failures due to missing rustfmt
- Allow deprecated items to suppress Borsh version warnings
- Prefix unused stake_amount variable with underscore
- Remove unused authorize_stake_pool method
- Remove unused gsol_mint_authority field from MetadataAccounts
- Fix doc comment indentation
- Remove unused import

All changes are safe and don't affect program functionality.
Remove extra blank line to pass cargo fmt check
Fix deprecated GitHub Actions artifact upload action
@vercel

vercel Bot commented Jul 21, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 7:50am

@dankelleher
dankelleher merged commit 615627c into develop Jul 21, 2025
10 checks passed
@dankelleher
dankelleher deleted the vite-migration branch July 21, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant