-
-
Notifications
You must be signed in to change notification settings - Fork 40
Adds peek() function for GenericSpectrogram
#188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MohamedAli1937
wants to merge
5
commits into
sunpy:main
Choose a base branch
from
MohamedAli1937:add-spectrogram-peek
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+62
−0
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2bf7b1d
Add peek() to GenericSpectrogram
MohamedAli1937 153718a
Add changelog for feature #188
MohamedAli1937 3215b57
Remove changelog entry for peek feature
MohamedAli1937 1275f6e
Update spectrogram docs and improve peek implementation
MohamedAli1937 4166f74
docs: use mock data in plot directive to fix build timeout
MohamedAli1937 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Add a ``peek()`` method to ``GenericSpectrogram``, which gives it a quick-look plotting functionality | ||
| similar to ``sunpy.map.Map.peek()`` and ``radiospectra.spectrum.Spectrum.peek()``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -107,3 +107,26 @@ def __repr__(self): | |||||
| f" {self.wavelength.min} - {self.wavelength.max}," | ||||||
| f" {self.start_time.isot} to {self.end_time.isot}>" | ||||||
| ) | ||||||
|
|
||||||
| def peek(self, **kwargs): | ||||||
| """ | ||||||
| Displays a quick-look plot of the Spectrogram with a colorbar. | ||||||
|
|
||||||
| Parameters | ||||||
| ---------- | ||||||
| **kwargs : `dict` | ||||||
| Any additional keyword arguments are passed to `~radiospectra.spectrogram.GenericSpectrogram.plot`. | ||||||
|
|
||||||
| Returns | ||||||
| ------- | ||||||
| `matplotlib.figure.Figure` | ||||||
| The figure object containing the plot. | ||||||
| """ | ||||||
| import matplotlib.pyplot as plt | ||||||
|
|
||||||
| figure = plt.figure() | ||||||
| axes = figure.add_subplot(111) | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't think this is needed
Suggested change
|
||||||
| ret = self.plot(axes=axes, **kwargs) | ||||||
| figure.colorbar(ret) | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should probably be an option in the method e.g. |
||||||
| figure.show() | ||||||
| return figure | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably use
@peek_showlike in sunpy so the figure isn't returned to have a similar API