Skip to content

Fix KeyError when accessing metadata for PSP RFS CDF files #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohamedAli1937 wants to merge 4 commits into
base: main
Choose a base branch
from
+38 −6
Open

Fix KeyError when accessing metadata for PSP RFS CDF files #187

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec06cae
Fix metadata key mismatch: rename cdf_globals to cdf_meta in factory
MohamedAli1937 Mar 26, 2026
bb90e6b
Add changelog for bugfix #187
MohamedAli1937 Mar 27, 2026
cf762a9
test: add remote data regression test and fix array attribute error i…
MohamedAli1937 Mar 27, 2026
82c9b35
test: add remote data regression test and fix array attribute error i…
MohamedAli1937 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/187.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Fix metadata key mismatch between ``SpectrogramFactory`` and ``RFSSpectrogram``.
The factory stored CDF global attributes under ``"cdf_globals"`` but ``RFSSpectrogram.level``
and ``RFSSpectrogram.version`` expected ``"cdf_meta"``, causing a ``KeyError`` when accessing
these properties on spectrograms created from real CDF files.
8 changes: 4 additions & 4 deletions radiospectra/spectrogram/spectrogram_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ def _read_cdf(file):
freqs = freqs[0, :] << u.Hz
data = data.T << u.Unit("Volt**2/Hz")
meta = {
"cdf_globals": cdf_globals,
"cdf_meta": cdf_globals,
"detector": detector,
"instrument": "FIELDS/RFS",
"observatory": "PSP",
Expand Down Expand Up @@ -458,7 +458,7 @@ def _read_cdf(file):
data = np.squeeze(data).T << sfu
detector = cdf_globals.get("Instrument", [""])[0].split(">")[0]
meta = {
"cdf_globals": cdf_globals,
"cdf_meta": cdf_globals,
"detector": detector,
"instrument": "RPW",
"observatory": "SOLO",
Expand Down Expand Up @@ -561,7 +561,7 @@ def _read_cdf(file):
res = []
if np.any(agc1):
meta1 = {
"cdf_globals": cdf_globals,
"cdf_meta": cdf_globals,
"detector": "RPW-AGC1",
"instrument": "RPW",
"observatory": "SOLO",
Expand All @@ -574,7 +574,7 @@ def _read_cdf(file):
res.append((specs[0].T, meta1))
if np.any(agc2):
meta2 = {
"cdf_globals": cdf_globals,
"cdf_meta": cdf_globals,
"detector": "RPW-AGC2",
"instrument": "RPW",
"observatory": "SOLO",
Expand Down