Adds slice method and associated tests#167
Open
MohamedAli1937 wants to merge 4 commits into
Open
Conversation
a856b6a to
b926fcc
Compare
Member
|
Hey thanks for the PR the implementation looks solid. But please see my comment on the corresponding issue. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds the slice() method to GenericSpectrogram to make it easier to extract a subset of the spectrogram by time and/or frequency. Previously, users had to manually compute array indices for slicing, which was error-prone.
fixes: #166
With this method:
spec.slice(time=(t_start, t_end), freq=(f_min, f_max))returns a newGenericSpectrogramcontaining only the requested subset.Metadata (
times,freqs,start_time,end_time,wavelength) is automatically updated.Original spectrogram remains unchanged.
Example:
AI Assistance Disclosure
AI tools were used for:
Screenshots:
test passed: