Skip to content
This repository was archived by the owner on Aug 18, 2023. It is now read-only.

feat: Add liveness checks to K8S manifests #20

Closed
arbourd wants to merge 1 commit into from
+48 −0
Closed

feat: Add liveness checks to K8S manifests #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions templates/k8s/e2core-deployment.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,15 @@ spec:
value: "info"
- name: APP_VERSION
value: {{ .AppVersion }}
livenessProbe:
httpGet:
path: /health
port: 8080
failureThreshold: 5
initialDelaySeconds: 10
periodSeconds: 15
timeoutSeconds: 3
readinessProbe:
httpGet:
path: /health
port: 8080
12 changes: 12 additions & 0 deletions templates/se2-k8s/.suborbital/e2core-deployment.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,18 @@ spec:
value: "info"
- name: E2CORE_CONTROL_PLANE
value: "se2-controlplane-service:8081"
livenessProbe:
httpGet:
path: /health
port: 8080
failureThreshold: 5
initialDelaySeconds: 10
periodSeconds: 15
timeoutSeconds: 3
readinessProbe:
httpGet:
path: /health
port: 8080
---
apiVersion: v1
kind: Service
Expand Down
24 changes: 24 additions & 0 deletions templates/se2-k8s/.suborbital/se2-controlplane-deployment.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,18 @@ spec:
value: "info"
- name: SE2_ENV_TOKEN
value: {{ .EnvToken }}
livenessProbe:
httpGet:
path: /api/v1/health
port: 8081
failureThreshold: 5
initialDelaySeconds: 10
periodSeconds: 15
timeoutSeconds: 3
readinessProbe:
httpGet:
path: /api/v1/health
port: 8081
volumeMounts:
- name: controlplane-storage
mountPath: "/home/se2"
Expand All @@ -50,6 +62,18 @@ spec:
value: "info"
- name: SE2_CONTROL_PLANE
value: "se2-controlplane-service:8081"
livenessProbe:
httpGet:
path: /api/v1/health
port: 8080
Comment on lines +67 to +68
Copy link
Copy Markdown
Contributor Author

@arbourd arbourd Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not work due to the builder only responding to the healthcheck on the TLS port when SE2_TLS_PORT is set. Is that true @cohix?

Copy link
Copy Markdown
Contributor

@danielledeleo danielledeleo Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arbourd I think we'll end up removing the se2-k8s template since that's for self-hosted.

Copy link
Copy Markdown
Contributor Author

@arbourd arbourd Dec 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya this is mostly preparation for suborbital/e2core#339, so whatever e2 is using. If we remove se2-k8s we can just rebase against that.

failureThreshold: 5
initialDelaySeconds: 10
periodSeconds: 15
timeoutSeconds: 3
readinessProbe:
httpGet:
path: /api/v1/health
port: 8080
volumeMounts:
- name: controlplane-storage
mountPath: "/home/se2"
Expand Down