Skip to content

Add ATASCII and PETSCII packages#9357

Open
thinkyhead wants to merge 1 commit intosublimehq:masterfrom
thinkyhead:atascii-package
Open

Add ATASCII and PETSCII packages#9357
thinkyhead wants to merge 1 commit intosublimehq:masterfrom
thinkyhead:atascii-package

Conversation

@thinkyhead
Copy link
Copy Markdown

@thinkyhead thinkyhead commented Apr 2, 2026

  • I'm the package's author and/or maintainer.
  • I have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My packages are ATASCII and PETSCII, adding support for "Atari Classic" and "Pet Me 64" Unicode fonts. Providing commands to open popup palettes to insert Unicode characters, and a command to invert ATASCII / PETSCII text. These packages may be used on their own with the appropriate fonts in any text file, but are best used with "Atari 800" and "Commodore 64" themes, and with "Atari BASIC" and "Commodore BASIC" syntaxes (also pending).

There are no packages like these in Package Control.

@kaste
Copy link
Copy Markdown
Contributor

kaste commented Apr 5, 2026

Good. Things in random order

  • .no-sublime-package; we usually don't want this; (e.g. way easier to override the Context menu if you don't set this); I also don't see on first look why this should be necessary you already use load_resource (you can likely hard-code the path instead of asking find_resource too).
  • all key bindings should be only examples; so comment them out; or change the name to Example.sublime-keymap (but then also change the Menu entry!)
  • Adding to the context menu -- don't think it is so useful here --; both is kinda hard for the user, removing it when you have add it, adding it when you don't. You could make it dynamic by writing (or removing) the file to sublime.cache_path() / <your-package-name> / or comment everything and add an entry to the Menu for copy pasting left-to-right.

Other than that good.

@braver braver added the feedback provided The changes and package have been seen by a reviewer label Apr 16, 2026
@github-actions
Copy link
Copy Markdown

Package Review

Channel Diff

Removed (none), changed (none), added ATASCII and PETSCII.

Review for ATASCII main-03831c0-2026.04.02.01.39.38

1 notices:
- Tip of main is tagged with 0.1.0. ✅
    Repository: https://github.com/thinkyhead/ATASCII

No failures

1 warnings:
- '.no-sublime-package' is defined. Please verify that it is *really* necessary


For more details on the report messages (for example how to resolve them), go to:
https://github.com/packagecontrol/st_package_reviewer/wiki

Review for PETSCII main-e12176a-2026.04.02.02.23.33

1 notices:
- Tip of main is tagged with 0.1.0. ✅
    Repository: https://github.com/thinkyhead/PETSCII

2 failures:
- The binding ['super+k', 'super+l'] unconditionally overrides a default binding
    File: Default.sublime-keymap
- The binding ['super+k', 'super+u'] unconditionally overrides a default binding
    File: Default.sublime-keymap

1 warnings:
- '.no-sublime-package' is defined. Please verify that it is *really* necessary


For more details on the report messages (for example how to resolve them), go to:
https://github.com/packagecontrol/st_package_reviewer/wiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback provided The changes and package have been seen by a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants