Merge pull request #52 from strvcom/feat/concurrency-improvements

[feat] Concurrency improvements

Author: ipek

.github/workflows/ci.yml

@@ -23,18 +23,14 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - name: 'iOS 17.2'
-            destination: 'OS=17.2,name=iPhone 15 Pro'
-            xcode: 'Xcode_15.2'
-            runsOn: macos-14
-#          - name: 'iOS 16.4'
-#            destination: 'OS=16.4,name=iPhone 14 Pro'
-#            xcode: 'Xcode_14.3.1'
-#            runsOn: macos-13
-          - name: 'macOS 13, Xcode 15.2'
+          - name: 'iOS 18.2, Xcode 16.2'
+            destination: 'OS=18.2,name=iPhone 16 Pro'
+            xcode: 'Xcode_16.2'
+            runsOn: macos-15
+          - name: 'macOS 15, Xcode 16.2'
             destination: 'platform=macOS'
-            xcode: 'Xcode_15.2'
-            runsOn: macos-14
+            xcode: 'Xcode_16.2'
+            runsOn: macos-15
     steps:
       - uses: actions/checkout@v4
 
@@ -43,11 +39,13 @@ jobs:
             set -o pipefail && \
             xcodebuild clean test -resultBundlePath "TestResults-${{ matrix.name }}" -skipPackagePluginValidation -scheme "Networking" -destination "${{ matrix.destination }}" | tee "build-log-${{ matrix.name }}.txt" | xcpretty
 
-      - uses: kishikawakatsumi/xcresulttool@v1
-        with:
-          path: 'TestResults-${{ matrix.name }}.xcresult'
-          title: '${{ matrix.name }} Test Results'
-        if: success() || failure()
+      # Missing Xcode 16 support
+      # https://github.com/kishikawakatsumi/xcresulttool/issues/765
+      # - uses: kishikawakatsumi/xcresulttool@v1
+      #   with:
+      #     path: 'TestResults-${{ matrix.name }}.xcresult'
+      #     title: '${{ matrix.name }} Test Results'
+      #   if: success() || failure()
 
       - name: 'Upload Build Log'
         uses: actions/upload-artifact@v4

.swiftlint.yml

@@ -11,6 +11,7 @@ analyzer_rules:
 # Rule identifiers to exclude from running.
 #
 disabled_rules:
+  - opening_brace
 
 #
 # Some rules are only opt-in. Find all the available rules by running: swiftlint rules

.swiftpm/xcode/xcshareddata/xcschemes/Networking.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1620"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

NetworkingSampleApp/NetworkingSampleApp.xcodeproj/project.pbxproj

@@ -302,7 +302,7 @@
 			attributes = {
 				BuildIndependentTargetsInParallel = YES;
 				LastSwiftUpdateCheck = 1240;
-				LastUpgradeCheck = 1500;
+				LastUpgradeCheck = 1620;
 				TargetAttributes = {
 					23A575B025F8B9DA00617551 = {
 						CreatedOnToolsVersion = 12.4;
@@ -537,7 +537,8 @@
 				);
 				PRODUCT_BUNDLE_IDENTIFIER = "com.strv.networking-sample-app";
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 5.0;
+				SWIFT_STRICT_CONCURRENCY = complete;
+				SWIFT_VERSION = 6.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
 			};
 			name = Debug;
@@ -557,7 +558,8 @@
 				);
 				PRODUCT_BUNDLE_IDENTIFIER = "com.strv.networking-sample-app";
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 5.0;
+				SWIFT_STRICT_CONCURRENCY = complete;
+				SWIFT_VERSION = 6.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
 			};
 			name = Release;

NetworkingSampleApp/NetworkingSampleApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1620"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

NetworkingSampleApp/NetworkingSampleApp.xcodeproj/xcshareddata/xcschemes/NetworkingSampleApp.xcscheme

@@ -8,6 +8,7 @@
 import Networking
 import Foundation
 
+@NetworkingActor
 final class SampleAuthorizationManager: AuthorizationManaging {
     let storage: AuthorizationStorageManaging = SampleAuthorizationStorageManager()
 

NetworkingSampleApp/NetworkingSampleApp/API/SampleAuthorizationManager.swift

@@ -7,7 +7,7 @@
 
 import Networking
 
-actor SampleAuthorizationStorageManager: AuthorizationStorageManaging {
+final class SampleAuthorizationStorageManager: AuthorizationStorageManaging {
     private var storage: AuthorizationData?
 
     func saveData(_ data: AuthorizationData) async throws {

NetworkingSampleApp/NetworkingSampleApp/API/SampleAuthorizationStorageManager.swift

@@ -10,8 +10,8 @@ import Foundation
 
 /// Maps NetworkError's unacceptableStatusCode 400 error to SampleAPIError.
 final class SampleErrorProcessor: ErrorProcessing {
-    private lazy var decoder = JSONDecoder()
-    
+    private let decoder = JSONDecoder()
+
     func process(_ error: Error, for endpointRequest: EndpointRequest) -> Error {
         guard let networkError = error as? NetworkError,
               case let .unacceptableStatusCode(statusCode, _, response) = networkError,

NetworkingSampleApp/NetworkingSampleApp/API/SampleErrorProcessor.swift

@@ -8,6 +8,7 @@
 import Foundation
 
 extension ByteCountFormatter {
+    @MainActor
     static let megaBytesFormatter: ByteCountFormatter = {
         let formatter = ByteCountFormatter()
         formatter.allowedUnits = [.useMB]