Skip to content

Commit aff66a9

Browse files
committed
Merge branch 'feat/concurrency-improvements' of github.com:strvcom/ios-networking into feat/concurrency-improvements
2 parents a6d12ef + f5721dc commit aff66a9

2 files changed

Lines changed: 14 additions & 24 deletions

File tree

Sources/Networking/Modifiers/Processors/EndpointRequestStorageProcessor/EndpointRequestStorageProcessor.swift

Lines changed: 14 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -28,32 +28,22 @@ open class EndpointRequestStorageProcessor: ResponseProcessing, ErrorProcessing
2828
private lazy var responsesDirectory = fileManager.temporaryDirectory.appendingPathComponent("responses")
2929
private lazy var requestCounter = Counter()
3030

31-
// This would ideally also be a lazy var, however it has to be async, because UIDevice.current.name needs to be called on MainActor.
32-
private var _multipeerConnectivityManager: MultipeerConnectivityManager?
33-
private var multipeerConnectivityManager: MultipeerConnectivityManager? {
34-
get async {
35-
// Initialise only in DEBUG mode otherwise it could pose a security risk for production apps.
36-
#if DEBUG
37-
guard _multipeerConnectivityManager == nil else {
38-
return _multipeerConnectivityManager
39-
}
40-
41-
guard let multiPeerSharingConfig = config.multiPeerSharing else {
42-
return nil
43-
}
44-
45-
let initialBuffer = multiPeerSharingConfig.shareHistory ? getAllStoredModels() : []
46-
47-
_multipeerConnectivityManager = MultipeerConnectivityManager(
48-
buffer: initialBuffer,
49-
deviceName: deviceName
50-
)
51-
return _multipeerConnectivityManager
52-
#else
31+
private lazy var multipeerConnectivityManager: MultipeerConnectivityManager? = {
32+
#if DEBUG
33+
guard let multipeerSharingConfig = config.multiPeerSharing else {
5334
return nil
54-
#endif
5535
}
56-
}
36+
37+
let initialBuffer = multipeerSharingConfig.shareHistory ? getAllStoredModels() : []
38+
39+
return MultipeerConnectivityManager(
40+
buffer: initialBuffer,
41+
deviceName: deviceName
42+
)
43+
#else
44+
return nil
45+
#endif
46+
}()
5747

5848
// MARK: Default shared instance
5949
public static let shared = EndpointRequestStorageProcessor(

Tests/NetworkingTests/Mocks/File.swift renamed to Tests/NetworkingTests/Mocks/MockResponseProviderError.swift

File renamed without changes.

0 commit comments

Comments
 (0)