web: remove saving note taking too long toast#9962
Open
thecodrr wants to merge 1 commit into
Open
Conversation
|
Cloudflare Pages Preview https://8fbc6d2e.notesnook-app.pages.dev Commit: eb6dba7 |
|
Desktop Previews Commit: eb6dba7 |
01zulfi
approved these changes
Jun 10, 2026
Comment on lines
-103
to
-109
| }), | ||
| new Promise((_, reject) => | ||
| setTimeout( | ||
| () => reject(new Error(strings.savingNoteTakingTooLong())), | ||
| 30 * 1000 | ||
| ) | ||
| ) |
Member
There was a problem hiding this comment.
Question: is there a reason to remove the 30s check to show the toast?
Contributor
Author
There was a problem hiding this comment.
The check is unreliable. Maybe there's a better way to do this reliably? Feel free to suggest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The toast was being showing even in cases where the note actually got saved.
Type of Change
Visuals
Testing
If tests were not added, explain why
Platform
Sign-off