core: fix inverted sort order in search relevance ranking#10081
Open
zigzagdev wants to merge 1 commit into
Open
core: fix inverted sort order in search relevance ranking#10081zigzagdev wants to merge 1 commit into
zigzagdev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix inverted sort comparators for relevance-based search results.
When sorting by relevance with
sortDirection: "desc", the comparator useda.rank - b.rank(ascending) instead ofb.rank - a.rank(descending), and vice versa.This caused search results to show the least relevant results first by default.
The same issue existed in both note search (
packages/core/src/api/lookup.ts:270) and trash search (lpackages/core/src/api/lookup.ts:710).Type of Change
Visuals
Testing
If tests were not added, explain why
Two-line fix swapping comparator operands. Existing search tests cover result matching but not sort order.
But if tests are required in this PR, I'll add it.
Platform
Sign-off