mobile: fix share append content merging onto same line#10042
Open
keyut-shah wants to merge 1 commit into
Open
mobile: fix share append content merging onto same line#10042keyut-shah wants to merge 1 commit into
keyut-shah wants to merge 1 commit into
Conversation
Replace the bare <br/> separator with an explicit <p data-spacing=single><br></p> paragraph. The bare <br/> was parsed into an implicit empty paragraph that inherited the live 'double spaced lines' setting; when that setting was off, the placeholder collapsed to zero height and appended content ran together on one line. Fixes streetwriters#9207 Signed-off-by: keyut-shah <keyutshah1@gmail.com>
ammarahm-ed
reviewed
Jul 6, 2026
| data: (rawContent?.data || "") + "<br/>" + noteContent.current, | ||
| data: | ||
| (rawContent?.data || "") + | ||
| `<p data-spacing="single"><br></p>` + |
Collaborator
There was a problem hiding this comment.
let's add data-spacing="single" only when double spaced lines are disabled by user?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the bare
separator with an explicit
paragraph. The barewas parsed into an implicit empty paragraph that inherited the live 'double spaced lines' setting; when that setting was off, the placeholder collapsed to zero height and appended content ran together on one line.
Fixes #9207
Description
Type of Change
Visuals
Testing
If tests were not added, explain why
Platform
Sign-off