Skip to content

Stability fixes and overlay evaluation script#389

Merged
marta-lokhova merged 6 commits into
stellar:mainfrom
marta-lokhova:slpEvalHardening
Jun 2, 2026
Merged

Stability fixes and overlay evaluation script#389
marta-lokhova merged 6 commits into
stellar:mainfrom
marta-lokhova:slpEvalHardening

Conversation

@marta-lokhova
Copy link
Copy Markdown
Contributor

  • Properly spin up watchers when in pregenerated txs mode
  • Upgrades: harden network limit calculation by including target block time in the calculation
  • Fix SAC txSize estimate for network limits
  • Fix broken support for simulate apply config flags
  • Bump init delay timer. Previously, the lower limit would cause some containers to get killed sporadically on startup

Copilot AI review requested due to automatic review settings May 28, 2026 23:57
@marta-lokhova marta-lokhova changed the title Stability fixes to MinBlockTest Stability fixes May 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves stability for supercluster test missions by making initialization work correctly in simulate/pregenerated transaction modes, tuning startup liveness timing, and recalculating network limits based on target block time.

Changes:

  • Re-enables stellar-core init commands during simulate-apply runs while keeping simulate-apply sleep settings out of init configs.
  • Adds pregenerated transaction watcher setup for non-loadgen nodes.
  • Reworks min-block-time network limit sizing to account for target close time and adjusts SAC transaction size estimates.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/FSLibrary/StellarKubeSpecs.fs Increases liveness initial delay and allows init commands to run in simulate-apply mode.
src/FSLibrary/StellarCoreCfg.fs Splits simulate-apply config behavior between init and main containers and adds trigger timer config.
src/FSLibrary/MinBlockTimeTest.fs Updates pregenerated tx setup and target-time-based classic/Soroban limit calculations.
src/FSLibrary/MaxTPSTest.fs Ensures non-loadgen nodes also run pregenerated tx initialization with zero txs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@marta-lokhova marta-lokhova changed the title Stability fixes Stability fixes and overlay evaluation script Jun 2, 2026
@marta-lokhova marta-lokhova requested review from bboston7 and dmkozh June 2, 2026 00:38
Comment thread scripts/slp_eval.sh
Comment thread scripts/slp_eval.sh
Comment thread src/FSLibrary/MinBlockTimeTest.fs
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74c54a4824

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread scripts/slp_eval.sh
@marta-lokhova marta-lokhova removed the request for review from bboston7 June 2, 2026 22:36
@marta-lokhova marta-lokhova merged commit 1fd7313 into stellar:main Jun 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants