Stability fixes and overlay evaluation script#389
Conversation
marta-lokhova
commented
May 28, 2026
- Properly spin up watchers when in pregenerated txs mode
- Upgrades: harden network limit calculation by including target block time in the calculation
- Fix SAC txSize estimate for network limits
- Fix broken support for simulate apply config flags
- Bump init delay timer. Previously, the lower limit would cause some containers to get killed sporadically on startup
There was a problem hiding this comment.
Pull request overview
This PR improves stability for supercluster test missions by making initialization work correctly in simulate/pregenerated transaction modes, tuning startup liveness timing, and recalculating network limits based on target block time.
Changes:
- Re-enables stellar-core init commands during simulate-apply runs while keeping simulate-apply sleep settings out of init configs.
- Adds pregenerated transaction watcher setup for non-loadgen nodes.
- Reworks min-block-time network limit sizing to account for target close time and adjusts SAC transaction size estimates.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/FSLibrary/StellarKubeSpecs.fs |
Increases liveness initial delay and allows init commands to run in simulate-apply mode. |
src/FSLibrary/StellarCoreCfg.fs |
Splits simulate-apply config behavior between init and main containers and adds trigger timer config. |
src/FSLibrary/MinBlockTimeTest.fs |
Updates pregenerated tx setup and target-time-based classic/Soroban limit calculations. |
src/FSLibrary/MaxTPSTest.fs |
Ensures non-loadgen nodes also run pregenerated tx initialization with zero txs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ae9c1f5 to
8c72006
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74c54a4824
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
2981b63 to
25c61c5
Compare
1f684b3 to
1c62120
Compare