go.mod: bump github.com/stellar/go-xdr to a87d4d0#5938
Merged
Conversation
Picks up stellar/go-xdr#31, which enforces MaxInputLen at the io.Reader boundary via io.LimitedReader. Decode semantics are unchanged for the generated UnmarshalBinary path (bytes.Reader length already bounds reads to len(inp)); microbenchmarks show a ~3% unmarshal overhead from the added wrapping. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the github.com/stellar/go-xdr dependency to pick up upstream changes that enforce MaxInputLen at the io.Reader boundary (via io.LimitedReader), aiming to improve safety without requiring downstream code changes.
Changes:
- Bump
github.com/stellar/go-xdrfromcc2b0611toa87d4d0ingo.mod. - Update
go.sumchecksums to match the newgo-xdrpseudo-version.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates the required github.com/stellar/go-xdr pseudo-version to the newer commit. |
| go.sum | Refreshes module and go.mod hashes for the updated go-xdr version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
leighmcculloch
approved these changes
Apr 23, 2026
urvisavla
pushed a commit
that referenced
this pull request
May 28, 2026
Picks up stellar/go-xdr#31, which enforces MaxInputLen at the io.Reader boundary via io.LimitedReader. Decode semantics are unchanged for the generated UnmarshalBinary path (bytes.Reader length already bounds reads to len(inp)); microbenchmarks show a ~3% unmarshal overhead from the added wrapping. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/stellar/go-xdrfromcc2b0611toa87d4d0to pick up stellar/go-xdr#31, which enforcesMaxInputLenat theio.Readerboundary viaio.LimitedReaderinstead of trusting the caller'slenLeftimplementation.UnmarshalBinaryare unchanged — thebytes.Readercreated frominpalready bounds reads tolen(inp), and the new upstream path enforces the same bound viaLimitedReader.🤖 Generated with Claude Code
EOF
)