-
Notifications
You must be signed in to change notification settings - Fork 11
Linearize Send Flow #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leofelix077
wants to merge
33
commits into
main
Choose a base branch
from
lf-linearize-send-flow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Linearize Send Flow #856
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
5e7b094
add initial version of linearizing send flow
leofelix077 6a18093
update keyboard avoiding view behavior for android
leofelix077 ceaf935
adjust keyboard avoiding view behavior for android
leofelix077 18084bd
add recipient name passing to review flow
leofelix077 1c517e6
fix navigation, typigns and input handling from typing and pasting
leofelix077 134bf87
Merge branch 'main' into lf-linearize-send-flow
leofelix077 fc3ab77
fix typings and reset search state
leofelix077 8cd4860
Merge branch 'lf-linearize-send-flow' of github.com:stellar/freighter…
leofelix077 60dc585
add back caret and remove highlighted hidden input
leofelix077 af8e4cc
fix ui elements from figma design
leofelix077 293fb05
adjust CI for android
leofelix077 4573eae
test no-keyboard option for android CI
leofelix077 616aca2
revert android ci option
leofelix077 0dc713b
fix copilot comments for virtualization
leofelix077 077872a
remove limit 10 recent contacts and add virtualization back
leofelix077 e4abc7f
adjust UI for wallets and invalid message
leofelix077 05a868c
clean stale state on collectible close
leofelix077 2aa00f1
fix collectible send flow
leofelix077 a5f5181
fix send flows when coming from details screens
leofelix077 618e545
fix memoization for nav headers
leofelix077 a5fb723
replace navigate with push and add e2e test for send from details
leofelix077 c9357ce
fix merge conflicts and adapt code to handle federated address on new…
leofelix077 04446e0
adjust safeguards for address truncation and fix scroll for tokens in…
leofelix077 7b6f9a5
adjust ui tweaks from figma and keyboard dismiss
leofelix077 20b7838
Merge branch 'main' into lf-linearize-send-flow
leofelix077 ca57079
fix navigation, align ui with figma latest design
leofelix077 e1e542a
adjust logic to hide usd conversion and has no price
leofelix077 bc3d2a1
adjust logic to hide usd conversion and has no price
leofelix077 efafeca
Merge branch 'main' into lf-linearize-send-flow
leofelix077 7ec7a9d
adjust memo type clearing on transaction amount screen and remove unu…
leofelix077 887e27e
adjust comments on federation memo type tests
leofelix077 10803db
Merge branch 'lf-linearize-send-flow' of github.com:stellar/freighter…
leofelix077 9c51a3e
enhance transaction test for federation memo type
leofelix077 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,8 +22,8 @@ jest.mock("hooks/useColors", () => ({ | |
| __esModule: true, | ||
| default: () => ({ | ||
| themeColors: { | ||
| foreground: { | ||
| primary: "#000000", | ||
| text: { | ||
| secondary: "#000000", | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also coming from discussion with @sdfcharles, to linearize the send collectible Screen.Recording.2026-05-12.at.15.28.21.movScreen.Recording.2026-05-12.at.15.31.24.mov |
||
| }, | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also adjusting the flows when coming from the details screens Screen.Recording.2026-05-12.at.16.22.56.mov |
||
| }, | ||
| }), | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two findings from @sdfcharles.
Should be minor changes that will not affect the final code, but will adjust soon and publish another version
1 to adjust the spacing between the search bar and the recents / first header
and 1 to rework a bit the collectibles to have a horizontal rule and numbering on the right side, to have a more distinct view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screen.Recording.2026-05-12.at.13.18.20.mov