feat: add 'zsh' tab completion#30
Open
wintermi wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Screenshot when performing a tab completion on
|
stefanmaric
requested changes
Jan 18, 2023
stefanmaric
left a comment
stefanmaric
left a comment
Owner
There was a problem hiding this comment.
@wintermi thanks for your interest and contribution.
I won't be merging this right ahead because I want to 1) have feature parity with fish and bash for all releases and 3) to sort how to embed this into g itself and its relationship with g-install as mentioned in the README TO-DO.
But definitely your contribution is very welcome specially taking into account that zsh's completion systems are quite complex.
| # Completing list of Remote Versions | ||
| __remoteVersions() { | ||
| declare -a remote_versions_cmd | ||
| remote_versions_cmd=( $(cat "$HOME/.cache/zsh-golang/go_versions") ) |
Owner
There was a problem hiding this comment.
This is not from g.
zsh has a cache policy feature in its completion system. Let's try to use that instead and call g list-all
stefanmaric
force-pushed
the
next
branch
18 times, most recently
from
ea12d81 to
592758a
Compare
stefanmaric
force-pushed
the
next
branch
3 times, most recently
from
3bb6509 to
5127f80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zshtab completion, providing:I created it as part of this
zshplugin - https://github.com/wintermi/zsh-golang