Do not define :init-ending if robot-model's :define-min-max-table exists.#510
Closed
snozawa wants to merge 1 commit into
Closed
Do not define :init-ending if robot-model's :define-min-max-table exists.#510snozawa wants to merge 1 commit into
snozawa wants to merge 1 commit into
Conversation
…ot define :init-ending if robot-model's :define-min-max-table exists (euslisp/jskeus#428). This will fix the bug (start-jsk#508) because unnecessary :init-ending conflict is resolved.
YoheiKakiuchi
left a comment
YoheiKakiuchi
left a comment
Member
There was a problem hiding this comment.
Is it needed for backward compatibility?
If so, it is better to add comment describe so.
And, it is better to add comment that :define-min-max-table is overridden, defined in irtrobot.l
Collaborator
Author
|
Close according to #509. |
itohdak
pushed a commit
to itohdak/rtmros_tutorials
that referenced
this pull request
Jan 10, 2019
[jsk_hrp2_ros_bridge/sensors_monitor.py] Add unit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not define :init-ending if robot-model's :define-min-max-table exists (euslisp/jskeus#428).
This will fix the bug (#508) because unnecessary :init-ending conflict is resolved.
Please check @YoheiKakiuchi.
If OK,please merge after euslisp/jskeus#428.