Skip to content

Fixed test failure in windows ie, testEcho() method #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kshitiz-Mhto wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fixed test failure in windows ie, testEcho() method #119

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b6bbcdc
fixed failing of testEcho() test in windows
Feb 14, 2023
010ffd4
fixed testEcho() test failure in windows
Feb 17, 2023
47be33d
added try catch block.
Feb 17, 2023
1a0eaa9
support to exceptions
Feb 17, 2023
5cc90da
Merge remote-tracking branch 'remotes/origin/testwin' into testwin
Feb 22, 2023
d33d671
fixed
Feb 22, 2023
d8ba5fb
removed unused library
Feb 22, 2023
a4594bb
fix handling multiple arguments
Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 36 additions & 14 deletions cli/src/main/java/dev/starfix/Starfix.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,22 +285,44 @@ public static void gitClone(Path directory, String originUrl) throws IOException

public static String runCommand(Path directory, String... command) throws IOException, InterruptedException {
// Function to Run Commands using Process Builder
ProcessResult presult;
try {
System.out.println("Running " + String.join(" ", command));
presult = new ProcessExecutor().command(command).redirectOutput(System.out).redirectErrorStream(true).readOutput(true)
.execute();
} catch (TimeoutException e) {
throw new RuntimeException("Error running command", e);
}
ProcessResult presult;

if (isWindows()) {
try{
System.out.println("Running " + String.join(" ", command));
presult = new ProcessExecutor().command("CMD", "/C", command[0], command[1]).redirectOutput(System.out).redirectErrorStream(true).readOutput(true)
Copy link
Copy Markdown
Collaborator

@fahad-israr fahad-israr Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you assuming that commands array will be of max size 2. can't there be more args than that ?
Infact there itself look at the gitClone Function which is calling run command with how many args:
runCommand(directory.getParent(), "git", "clone", originUrl, directory.toString());

Copy link
Copy Markdown
Author

@Kshitiz-Mhto Kshitiz-Mhto Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my mistake. its done now I think.

.execute();
} catch (Exception e) {
throw new RuntimeException("Error running command", e);
}

int exit = presult.getExitValue();
if (exit!=0) {
throw new AssertionError(
String.format("runCommand %s in %s returned %d", Arrays.toString(command), directory, exit));
}
int exit = presult.getExitValue();
if (exit!=0) {
throw new AssertionError(
String.format("runCommand %s in %s returned %d", Arrays.toString(command), directory, exit));
}

return presult.outputUTF8().replaceAll("\"","");

} else{

try {
System.out.println("Running " + String.join(" ", command));
presult = new ProcessExecutor().command(command).redirectOutput(System.out).redirectErrorStream(true).readOutput(true)
.execute();
} catch (TimeoutException e) {
throw new RuntimeException("Error running command", e);
}

int exit = presult.getExitValue();
if (exit!=0) {
throw new AssertionError(
String.format("runCommand %s in %s returned %d", Arrays.toString(command), directory, exit));
}

return presult.outputUTF8();

return presult.outputUTF8();
}
}

public static class CloneUrl{
Expand Down