Make bindings more ideomatic.#2
Open
AndrewKraevskii wants to merge 8 commits into
Open
Conversation
added 8 commits
June 23, 2026 12:23
This is faster and we don't need to use global Io extra time.
This is just managed version of array_hashmap.String.
Making it unmanaged tells uset in api what passing it as parameted doesn't modify it.
I think we can mitigate a bit more code by adding
initElement(arena, &.{.{key1, value1, .{key2, value2}}}); init method to that datastructure.
It already exists on StaticStringMap so i don't think anyone would be agains it.
This gives users more flexability on where to actually put buffer and how large to actually make buffer. And also makes Message non intrusive data structure which allows nicer initialization. This also allows to remove default field values which removes footgun of incorrect initializations.
They actually just don't test anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is based on top of #1 which are more critical.
Read commit descriptions for more info on each specific change.