Skip to content

Support Ruby 3#32

Merged
PeterJCLaw merged 1 commit into
masterfrom
support-ruby-3
Jan 22, 2023
Merged

Support Ruby 3#32
PeterJCLaw merged 1 commit into
masterfrom
support-ruby-3

Conversation

@PeterJCLaw

Copy link
Copy Markdown
Member

This ports the changes from srobo/website#473.

This isn't officially supported by Jekyll and is a bit hacky, so I'm deliberately not documenting the support, however as recent Ubuntu versions now ship with Ruby 3 (not 2.7) and Jekyll isn't showing any signs of moving towards supporting Ruby 3 we're not left with many alternatives.

This ports the changes from srobo/website#473.

This isn't officially supported by Jekyll and is a bit hacky, so
I'm deliberately not documenting the support, however as recent
Ubuntu versions now ship with Ruby 3 (not 2.7) and Jekyll isn't
showing any signs of moving towards supporting Ruby 3 we're not
left with many alternatives.
@PeterJCLaw PeterJCLaw requested a review from raccube January 8, 2023 19:32

@raccube raccube left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Ruby 3.1.2 on macOS/arm64. Should also update this to use Bundler 2.

@raccube

raccube commented Jan 22, 2023

Copy link
Copy Markdown
Member

This does not work on 3.2 btw

@PeterJCLaw PeterJCLaw merged commit 03fed5e into master Jan 22, 2023
@PeterJCLaw PeterJCLaw deleted the support-ruby-3 branch January 22, 2023 13:35
@PeterJCLaw PeterJCLaw temporarily deployed to github-pages January 22, 2023 13:36 — with GitHub Pages Inactive
@PeterJCLaw

Copy link
Copy Markdown
Member Author

For reference I'm using 3.0:

$ ruby --version
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux-gnu]

This does not work on 3.2 btw

Ah, would you be able to raise an issue for that (probably against the website as that presumably has the same issue?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants