Skip to content

Unified spacing config#1461

Open
Hummer12007 wants to merge 1 commit intosquidowl:mainfrom
Hummer12007:unified-spacing
Open

Unified spacing config#1461
Hummer12007 wants to merge 1 commit intosquidowl:mainfrom
Hummer12007:unified-spacing

Conversation

@Hummer12007
Copy link
Copy Markdown
Contributor

No description provided.

@Hummer12007 Hummer12007 force-pushed the unified-spacing branch 2 times, most recently from f8b8ca7 to 29541b2 Compare February 10, 2026 18:20
Copy link
Copy Markdown
Member

@casperstorm casperstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I am not sure i want to go the direction of unifing spacing in a single new setting. I have been thinking quite a lot about it but i think i rather have a user go through each setting and then see all that is relevant that way. And then further enhance this by guides like: https://halloy.chat/guides/single-pane.html

However i am NOT against adding a ton of spacing options, we should just put it under the relevant structs, and then make a guide for "adjusting global space" or similar.

@Hummer12007
Copy link
Copy Markdown
Contributor Author

Alright. Let's bikeshed the incoming config additions here now, then.

I asked an agent to helpfully summarize the tweaks I've made and propose the config keys.

Change Code Unified key Non-unified key
Buffer/pane/titlebar/input border radius src/appearance/theme/container.rs:24,43,58
src/appearance/theme/pane_grid.rs:30
spacing.pane.border_radius pane.border_radius
Pane title bar padding src/screen/dashboard/pane.rs:440 spacing.pane.title_bar_padding pane.title_bar_padding
Topic banner spacing src/buffer/channel/topic.rs:178 spacing.buffer.topic_spacing buffer.channel.topic_spacing
Text editor inner padding src/buffer/input_view.rs:289 spacing.input.padding buffer.text_input.padding
Input container padding src/buffer/input_view.rs:528 spacing.input.container_padding buffer.text_input.container_padding
Input row top padding + row spacing src/buffer/input_view.rs:531,532 spacing.input.top_padding buffer.text_input.top_padding
Completion entry padding src/buffer/input_view/completion.rs:952,2701 spacing.completion.entry_padding buffer.text_input.completion_entry_padding
Completion tooltip padding src/buffer/input_view/completion.rs:963,2712 spacing.completion.tooltip_padding buffer.text_input.completion_tooltip_padding
Command bar padding src/screen/dashboard/command_bar.rs:76 spacing.command_bar.padding command_bar.padding
Sidebar top padding src/screen/dashboard/sidebar.rs:679,684 spacing.sidebar.padding.top sidebar.padding.top
Sidebar buffer list row spacing src/screen/dashboard/sidebar.rs:634 spacing.sidebar.spacing.buffer sidebar.spacing.buffer
Sidebar nicklist container padding src/screen/dashboard/sidebar.rs:610 spacing.sidebar.nicklist_padding sidebar.padding.nicklist

How do they feel to you? (the non-unified ones)

@casperstorm
Copy link
Copy Markdown
Member

I think thats fine, in short - it should go under the config struct it relates to.
on pane we have gap right now so you can add a spacing and padding there:

[pane.spacing]
border_radius = ..

[pane.padding]
title_bar = ...

same with buffer.text_input we want a padding there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants