Conversation
d42a6c8 to
db34cd6
Compare
|
Needs to be improved a little first. |
96e10db to
a05d049
Compare
|
First of all, I like the feature. Good job implementing it. However, I don’t like the way we are “hammering” more complexity into the current side menu. The side menu is already quite a sore point for me. For once the I have talked with @andymandias about a way forward, and we came up with a new system which also makes the entire thing a little more "halloy-ish". It will, however require quite a big refactor. A refactor which you shoudn't feel forced to do, i don't mind picking it up. The main idea is
We can persist position and pane types to the Each pane, eg external buffer, needs to answer a question of "can i be displayed both horizontally or vertically?" and if so implement that logic. For those panes that doesnt work horizontally, eg nicklist, we can then display a "This pane isn't supported in horizntal mode" Then at the end of the day we end up with something like (pesudo code) Problems with this as i can see is:
Benefits:
This is up for discussion.
|
|
I'll prototype a bit to see how it turns out, and to see if this is a viable way to go. |
|
An important thing I wanted to account for here:
|

Disabled by default. Should keep things as is when not enabled.