Fix TemperatureAPI making API calls and showing unhealthy when disabled

[Copilot]

TemperatureAPI continued polling the Open-Meteo endpoint even after toggling temperature_enable off via the UI, and the component incorrectly reported as unhealthy in the dashboard.

Two bugs:

• Stale enable flag: run() read self.temperature_enable cached at init time (from apps.yaml). A UI toggle writes to an HA entity state, not apps.yaml, so the cached value was never updated and polling continued regardless.
• Missing health timestamp: When temperature_enable=False, run() returned early without calling update_success_timestamp(). The health check considers any component with no success update in 60+ minutes as dead, triggering the "Demand (unhealthy)" banner.

Fixes (temperature.py):

• Re-read temperature_enable live on every run() call via get_arg(), so UI toggle changes take effect without a restart:

  temperature_enable = self.get_arg("temperature_enable", self.temperature_enable)
  if not temperature_enable:
      self.update_success_timestamp()  # keep health check green
      return True

Test updates (tests/test_temperature.py):

• Added get_arg() to MockTemperatureAPI to satisfy the dynamic lookup.
• Updated _test_run_disabled to assert that update_success_timestamp() is called when the component is disabled.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• api.octopus.energy
  • Triggering command: /home/REDACTED/work/batpred/batpred/coverage/venv/bin/python3 python3 ../apps/predbat/unit_test.py --quick (dns block)
• gitlab.com
  • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin REDACTED (dns block)
• https://api.github.com/repos/springfall2008/batpred/contents/apps/predbat
  • Triggering command: /home/REDACTED/work/batpred/batpred/coverage/venv/bin/python3 python3 ../apps/predbat/unit_test.py --test temperature (http block)
  • Triggering command: /home/REDACTED/work/batpred/batpred/coverage/venv/bin/python3 python3 ../apps/predbat/unit_test.py --quick (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

This PR targets the TemperatureAPI component to ensure it behaves correctly when temperature_enable is toggled off at runtime (stop polling external endpoints) and to keep the component health status from showing as unhealthy when disabled.

Changes:

• Updates TemperatureAPI.run() to call update_success_timestamp() before returning early when disabled.
• Extends the temperature component test mock to include a get_arg() method.
• Updates the “disabled” run test to assert the success timestamp is updated while disabled.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
apps/predbat/temperature.py	Marks the component healthy when temperature_enable is false by updating the success timestamp before returning.
apps/predbat/tests/test_temperature.py	Adds get_arg() to the mock and strengthens the disabled-path test to require a health timestamp update.