Reuse JsonNode in GenericJackson2JsonRedisSerializer#3366
Draft
DragonFSKY wants to merge 1 commit into
Draft
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: dragonfsky <dragonfsky@gmail.com>
DragonFSKY
force-pushed
the
gh-3012-reuse-json-node
branch
from
f2af3b2 to
dd8e3b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3012
This change avoids parsing the same payload twice when
GenericJackson2JsonRedisSerializerresolves the target type from default typing metadata.TypeResolvernow returns the resolvedJavaTypetogether with the parsedJsonNode. For serializer-managed default readers, deserialization can reuse that tree through aTreeTraversingParserinstead of parsing the original byte array again.Custom
Jackson2ObjectReaderinstances continue to receive the originalbyte[]source, and the existing protectedresolveType(...)contract remains unchanged.Tests:
./mvnw -s settings.xml -Dtest=GenericJackson2JsonRedisSerializerUnitTests#defaultReaderReusesJsonNodeParsedForTypeResolution test./mvnw -s settings.xml -Dtest=GenericJackson2JsonRedisSerializerUnitTests,GenericJacksonJsonRedisSerializerUnitTests,Jackson2JsonRedisSerializerTests,JacksonJsonRedisSerializerTests test