Deprecate duplicate String properties converter#3365
Open
akimoovv wants to merge 1 commit into
Open
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
StringToPropertiesConverterand delegates its conversion logic to the sharedConverters.toProperties(String)implementation.This removes the duplicate String-to-Properties parsing path while preserving the existing converter type for compatibility. A focused converter test was added to cover Redis INFO-style property conversion through the shared converter API.
Closes gh-3020.
Tests:
./mvnw -Dtest=ConvertersUnitTests test./mvnw -DskipTests verifyNote:
./mvnw verifywas also attempted, but local integration tests require Redis on localhost:6379 and failed because Redis was not available.