Fix #1324: Add @JsonAlias support to SimplePageable for SNAKE_CASE compatibility

spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/support/PageJacksonModule.java

@@ -242,7 +242,10 @@ static class SimplePageable implements Pageable {
 
 		private final PageRequest delegate;
 
-		SimplePageable(@JsonProperty("pageNumber") int number, @JsonProperty("pageSize") int size,
+		SimplePageable(
+				@JsonProperty("pageNumber") @JsonAlias({ "page-number", "page_number", "pagenumber",
+						"PageNumber" }) int number,
+				@JsonProperty("pageSize") @JsonAlias({ "page-size", "page_size", "pagesize", "PageSize" }) int size,
 				@JsonProperty("sort") Sort sort) {
 			delegate = buildPageRequest(number, size, sort);
 		}

spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/support/PageJacksonModuleTests.java

@@ -22,6 +22,7 @@
 
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.PropertyNamingStrategies;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
@@ -188,4 +189,83 @@ void serializeAndDeserializeFilledMultipleCascade() throws JsonProcessingExcepti
 		assertThat(cascadedResult.getPageable().getPageNumber()).isEqualTo(6);
 	}
 
+	@Test
+	void deserializePageableWithHyphenatedAlias() throws IOException {
+		// Given
+		ObjectMapper kebabOjectMapepr = objectMapper.copy();
+		kebabOjectMapepr.setPropertyNamingStrategy(PropertyNamingStrategies.KEBAB_CASE);
+		File file = new File("./src/test/resources/withPageableAliasHyphen.json");
+		// When
+		Page<?> result = kebabOjectMapepr.readValue(file, Page.class);
+		// Then
+		assertThat(result).isNotNull();
+		assertThat(result.getTotalElements()).isEqualTo(15);
+		assertThat(result.getContent()).hasSize(10);
+		assertThat(result.getPageable()).isNotNull();
+		assertThat(result.getPageable().getPageNumber()).isEqualTo(2);
+		assertThat(result.getPageable().getPageSize()).isEqualTo(3);
+		assertThat(result.getPageable().getSort().getOrderFor("firstName").getDirection())
+			.isEqualTo(Sort.Direction.ASC);
+	}
+
+	@Test
+	void deserializePageableWithUnderscoreAlias() throws IOException {
+		// Given
+		ObjectMapper snakeCaseMapper = objectMapper.copy();
+		snakeCaseMapper.setPropertyNamingStrategy(PropertyNamingStrategies.SNAKE_CASE);
+		File file = new File("./src/test/resources/withPageableAliasUnderscore.json");
+
+		// When
+		Page<?> result = snakeCaseMapper.readValue(file, Page.class);
+		// Then
+		assertThat(result).isNotNull();
+		assertThat(result.getTotalElements()).isEqualTo(10);
+		assertThat(result.getContent()).hasSize(10);
+		assertThat(result.getPageable()).isNotNull();
+		assertThat(result.getPageable().getPageNumber()).isEqualTo(1);
+		assertThat(result.getPageable().getPageSize()).isEqualTo(2);
+		assertThat(result.getPageable().getSort().getOrderFor("lastName").getDirection())
+			.isEqualTo(Sort.Direction.DESC);
+	}
+
+	@Test
+	void deserializePageableWithLowercaseAlias() throws IOException {
+		// Given
+		ObjectMapper lowerCaseMapper = objectMapper.copy();
+		lowerCaseMapper.setPropertyNamingStrategy(PropertyNamingStrategies.LOWER_CASE);
+
+		File file = new File("./src/test/resources/withPageableAliasLowercase.json");
+
+		// When
+		Page<?> result = lowerCaseMapper.readValue(file, Page.class);
+		// Then
+		assertThat(result).isNotNull();
+		assertThat(result.getTotalElements()).isEqualTo(8);
+		assertThat(result.getContent()).hasSize(10);
+		assertThat(result.getPageable()).isNotNull();
+		assertThat(result.getPageable().getPageNumber()).isEqualTo(0);
+		assertThat(result.getPageable().getPageSize()).isEqualTo(4);
+		assertThat(result.getPageable().getSort()).isEqualTo(Sort.unsorted());
+	}
+
+	@Test
+	void deserializePageableWithPascalCaseAlias() throws IOException {
+		// Given
+		ObjectMapper upperCamelCaseMapper = objectMapper.copy();
+		upperCamelCaseMapper.setPropertyNamingStrategy(PropertyNamingStrategies.UPPER_CAMEL_CASE);
+		File file = new File("./src/test/resources/withPageableAliasPascalCase.json");
+
+		// When
+		Page<?> result = upperCamelCaseMapper.readValue(file, Page.class);
+		// Then
+		assertThat(result).isNotNull();
+		assertThat(result.getTotalElements()).isEqualTo(20);
+		assertThat(result.getContent()).hasSize(10);
+		assertThat(result.getPageable()).isNotNull();
+		assertThat(result.getPageable().getPageNumber()).isEqualTo(3);
+		assertThat(result.getPageable().getPageSize()).isEqualTo(2);
+		assertThat(result.getPageable().getSort().getOrderFor("firstName").getDirection())
+			.isEqualTo(Sort.Direction.ASC);
+	}
+
 }

spring-cloud-openfeign-core/src/test/resources/withPageableAliasHyphen.json

@@ -0,0 +1,77 @@
+{
+	"content": [
+		{
+			"id": 3,
+			"lastName": "Williams",
+			"firstName": "Thomas",
+			"email": "w.t@my.domain.com"
+		},
+		{
+			"id": 1,
+			"lastName": "Smith",
+			"firstName": "James",
+			"email": "s.j@my.domain.com"
+		},
+		{
+			"id": 11,
+			"lastName": "Scott",
+			"firstName": "Steven",
+			"email": "s.s@my.domain.com"
+		},
+		{
+			"id": 8,
+			"lastName": "Rodriguez",
+			"firstName": "Daniel",
+			"email": "r.d@my.domain.com"
+		},
+		{
+			"id": 9,
+			"lastName": "Martinez",
+			"firstName": "Robert",
+			"email": "m.r@my.domain.com"
+		},
+		{
+			"id": 5,
+			"lastName": "Jones",
+			"firstName": "James",
+			"email": "j.j@my.domain.com"
+		},
+		{
+			"id": 2,
+			"lastName": "Johnson",
+			"firstName": "Robert",
+			"email": "j.r@my.domain.com"
+		},
+		{
+			"id": 6,
+			"lastName": "Garcia",
+			"firstName": "William",
+			"email": "g.w@my.domain.com"
+		},
+		{
+			"id": 7,
+			"lastName": "Davis",
+			"firstName": "Richard",
+			"email": "d.r@my.domain.com"
+		},
+		{
+			"id": 4,
+			"lastName": "Brown",
+			"firstName": "Paul",
+			"email": "b.p@my.domain.com"
+		}
+	],
+	"pageable": {
+		"page-number": 2,
+		"page-size": 3,
+		"sort": {
+			"orders": [
+				{
+					"direction": "ASC",
+					"property": "firstName"
+				}
+			]
+		}
+	},
+	"totalElements": 15
+}

spring-cloud-openfeign-core/src/test/resources/withPageableAliasLowercase.json

@@ -0,0 +1,72 @@
+{
+	"content": [
+		{
+			"id": 3,
+			"lastName": "Williams",
+			"firstName": "Thomas",
+			"email": "w.t@my.domain.com"
+		},
+		{
+			"id": 1,
+			"lastName": "Smith",
+			"firstName": "James",
+			"email": "s.j@my.domain.com"
+		},
+		{
+			"id": 11,
+			"lastName": "Scott",
+			"firstName": "Steven",
+			"email": "s.s@my.domain.com"
+		},
+		{
+			"id": 8,
+			"lastName": "Rodriguez",
+			"firstName": "Daniel",
+			"email": "r.d@my.domain.com"
+		},
+		{
+			"id": 9,
+			"lastName": "Martinez",
+			"firstName": "Robert",
+			"email": "m.r@my.domain.com"
+		},
+		{
+			"id": 5,
+			"lastName": "Jones",
+			"firstName": "James",
+			"email": "j.j@my.domain.com"
+		},
+		{
+			"id": 2,
+			"lastName": "Johnson",
+			"firstName": "Robert",
+			"email": "j.r@my.domain.com"
+		},
+		{
+			"id": 6,
+			"lastName": "Garcia",
+			"firstName": "William",
+			"email": "g.w@my.domain.com"
+		},
+		{
+			"id": 7,
+			"lastName": "Davis",
+			"firstName": "Richard",
+			"email": "d.r@my.domain.com"
+		},
+		{
+			"id": 4,
+			"lastName": "Brown",
+			"firstName": "Paul",
+			"email": "b.p@my.domain.com"
+		}
+	],
+	"pageable": {
+		"pagenumber": 0,
+		"pagesize": 4,
+		"sort": {
+			"orders": []
+		}
+	},
+	"totalElements": 8
+}

spring-cloud-openfeign-core/src/test/resources/withPageableAliasPascalCase.json

@@ -0,0 +1,77 @@
+{
+	"content": [
+		{
+			"id": 3,
+			"lastName": "Williams",
+			"firstName": "Thomas",
+			"email": "w.t@my.domain.com"
+		},
+		{
+			"id": 1,
+			"lastName": "Smith",
+			"firstName": "James",
+			"email": "s.j@my.domain.com"
+		},
+		{
+			"id": 11,
+			"lastName": "Scott",
+			"firstName": "Steven",
+			"email": "s.s@my.domain.com"
+		},
+		{
+			"id": 8,
+			"lastName": "Rodriguez",
+			"firstName": "Daniel",
+			"email": "r.d@my.domain.com"
+		},
+		{
+			"id": 9,
+			"lastName": "Martinez",
+			"firstName": "Robert",
+			"email": "m.r@my.domain.com"
+		},
+		{
+			"id": 5,
+			"lastName": "Jones",
+			"firstName": "James",
+			"email": "j.j@my.domain.com"
+		},
+		{
+			"id": 2,
+			"lastName": "Johnson",
+			"firstName": "Robert",
+			"email": "j.r@my.domain.com"
+		},
+		{
+			"id": 6,
+			"lastName": "Garcia",
+			"firstName": "William",
+			"email": "g.w@my.domain.com"
+		},
+		{
+			"id": 7,
+			"lastName": "Davis",
+			"firstName": "Richard",
+			"email": "d.r@my.domain.com"
+		},
+		{
+			"id": 4,
+			"lastName": "Brown",
+			"firstName": "Paul",
+			"email": "b.p@my.domain.com"
+		}
+	],
+	"pageable": {
+		"PageNumber": 3,
+		"PageSize": 2,
+		"sort": {
+			"orders": [
+				{
+					"direction": "ASC",
+					"property": "firstName"
+				}
+			]
+		}
+	},
+	"totalElements": 20
+}