Add MonoToMulti plugin wrapper for per-channel processing#487
Open
codyjhsieh wants to merge 1 commit into
Open
Add MonoToMulti plugin wrapper for per-channel processing#487codyjhsieh wants to merge 1 commit into
codyjhsieh wants to merge 1 commit into
Conversation
Problem Pedalboard has ForceMono for mixing multichannel audio down to mono before processing, but no inverse — a wrapper that takes a mono-only plugin and runs it independently on each channel of a multichannel signal. This was noted as a TODO in FixedBlockSize.h:254. Solution Add MonoToMulti<T> template in plugin_templates/MonoToMulti.h. It allocates one instance of the wrapped plugin per channel using unique_ptr (plugins are non-copyable due to std::mutex), prepares each with a mono ProcessSpec, and processes each channel through its own instance. Includes a test plugin registered in _internal. Result Mono plugins can now be used in stereo or multichannel contexts without cross-channel interference. The TODO is resolved. ForceMono (mixdown) and MonoToMulti (fan-out) are now complementary wrappers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pedalboard has
ForceMono<T>for mixing multichannel audio down to mono before processing, but no inverse — a wrapper that takes a mono-only plugin and runs it independently on each channel of a multichannel signal. This was noted as a TODO inFixedBlockSize.h:254, added in #76.Solution
Add
MonoToMulti<T>template inplugin_templates/MonoToMulti.h. It allocates one instance of the wrapped plugin per channel usingunique_ptr(plugins are non-copyable due tostd::mutex), prepares each with a monoProcessSpec, and processes each channel through its own instance. Includes a test plugin registered in_internal.Result
Mono plugins can now be used in stereo or multichannel contexts without cross-channel interference.
ForceMono(mixdown) andMonoToMulti(fan-out) are now complementary wrappers. The TODO is resolved.