Added 10 salvage wrecks to the magnet

[Bandirpvp]

About the PR

Added 10 more salvage wrecks to the salvage magnet roster. 5 Small, 3 Medium and 2 Large. (Note that this is my first PR ever so if theres anything wrong with it please lmk)

Why / Balance

After playing salvage for a long while I have realized that many of the current salvage wrecks are underwhelming at best. I have decided to add a few more in order to spice them up. Add a way to obtain some currently unobtainable items for the crew (for ex. compact defibrilator) and generally make salvage more fun while also increasing the salvage wreck roster making them just a little more random.

Technical details

Added 10 new salvage wreck .yml files inside Resources/Maps/Salvage and updated the salvage magnet roster (Resources/Prototypes/Maps/salvage.yml) to make them spawn trough the magnet pulls. (I got no clue why meatball.yml and small-party.yml got upated since i havent changed their code at all.)

Media


Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an in-game showcase.

Breaking changes

Changelog
Add a Changelog entry to make players aware of new features or changes that could affect gameplay.
Make sure to read the guidelines and take this Changelog template out of the comment block in order for it to show up.
Changelog must have a 🆑 symbol, so the bot recognizes the changes and adds them to the game's changelog.
🆑

• add: Salvage wreck "small-defibwreck.yml"
• add: Salvage wreck "small-johnspiderclan.yml"
• add: Salvage wreck "small-mercsand.yml"
• add: Salvage wreck "small-scichunk.yml"
• add: Salvage wreck "small-xenochunk.yml"
• add: Salvage wreck "medium-freelancershuttle.yml"
• add: Salvage wreck "medium-diamondroid.yml"
• add: Salvage wreck "medium-brigmed.yml"
• add: Salvage wreck "large-xenoroid.yml"
• add: Salvage wreck "large-syndieoutpost.yml"

[SnappingOpossum]

Would be nice to see the spawners of these from when they're being mapped. Other than that you don't need to keep the section talking about the changelog, and the changelog itself would be better like the title currently is instead of listing the added files.

[Bandirpvp]

Posting images of the spawns + the one wreck that didnt load properly in the main post:

[SnappingOpossum]

Hadn't noticed before, but these spacing and EOF lines should be empty.

[SnappingOpossum]

Suggested change

	- type: salvageMap
	id: SmallDefibwreck
	mapPath: /Maps/Salvage/small-defibwreck.yml
	sizeString: salvage-map-wreck-size-small
	- type: salvageMap
	id: SmallJohnspiderclan
	mapPath: /Maps/Salvage/small-johnspiderclan.yml
	sizeString: salvage-map-wreck-size-small
	- type: salvageMap
	id: SmallXenoChunk
	mapPath: /Maps/Salvage/small-xenochunk.yml
	sizeString: salvage-map-wreck-size-small
	- type: salvageMap
	id: SmallScichunk
	mapPath: /Maps/Salvage/small-scichunk.yml
	sizeString: salvage-map-wreck-size-small
	- type: salvageMap
	id: SmallMercsand
	mapPath: /Maps/Salvage/small-mercsand.yml
	sizeString: salvage-map-wreck-size-small
	- type: salvageMap
	id: SmallDefibwreck
	mapPath: /Maps/Salvage/small-defibwreck.yml
	sizeString: salvage-map-wreck-size-small
	- type: salvageMap
	id: SmallJohnspiderclan
	mapPath: /Maps/Salvage/small-johnspiderclan.yml
	sizeString: salvage-map-wreck-size-small
	- type: salvageMap
	id: SmallXenoChunk
	mapPath: /Maps/Salvage/small-xenochunk.yml
	sizeString: salvage-map-wreck-size-small
	- type: salvageMap
	id: SmallScichunk
	mapPath: /Maps/Salvage/small-scichunk.yml
	sizeString: salvage-map-wreck-size-small
	- type: salvageMap
	id: SmallMercsand
	mapPath: /Maps/Salvage/small-mercsand.yml
	sizeString: salvage-map-wreck-size-small

[SnappingOpossum]

Suggested change

	- type: salvageMap
	id: MediumBrigmed
	mapPath: /Maps/Salvage/medium-brigmed.yml
	sizeString: salvage-map-wreck-size-medium
	- type: salvageMap
	id: MediumFreelancershuttle
	mapPath: /Maps/Salvage/medium-freelancershuttle.yml
	sizeString: salvage-map-wreck-size-medium
	- type: salvageMap
	id: MediumDiamondroid
	mapPath: /Maps/Salvage/medium-diamondroid.yml
	sizeString: salvage-map-wreck-size-medium
	- type: salvageMap
	id: MediumBrigmed
	mapPath: /Maps/Salvage/medium-brigmed.yml
	sizeString: salvage-map-wreck-size-medium
	- type: salvageMap
	id: MediumFreelancershuttle
	mapPath: /Maps/Salvage/medium-freelancershuttle.yml
	sizeString: salvage-map-wreck-size-medium
	- type: salvageMap
	id: MediumDiamondroid
	mapPath: /Maps/Salvage/medium-diamondroid.yml
	sizeString: salvage-map-wreck-size-medium

[SnappingOpossum]

Suggested change

	- type: salvageMap
	id: LargeSyndieoutpost
	mapPath: /Maps/Salvage/large-syndieoutpost.yml
	sizeString: salvage-map-wreck-size-large
	- type: salvageMap
	id: LargeXenoroid
	mapPath: /Maps/Salvage/large-xenoroid.yml
	sizeString: salvage-map-wreck-size-large
	- type: salvageMap
	id: LargeSyndieoutpost
	mapPath: /Maps/Salvage/large-syndieoutpost.yml
	sizeString: salvage-map-wreck-size-large
	- type: salvageMap
	id: LargeXenoroid
	mapPath: /Maps/Salvage/large-xenoroid.yml
	sizeString: salvage-map-wreck-size-large

[Bandirpvp]

Won't be able to change these most likely till Monday. I'll respond again when I'll add these changes

[Bandirpvp]

Commit with the changes pushed.

[kopelthep]

Hey, salvager main here, LOVE the additions, my only problem is the turrets. considering this is gonna be on magnet not persistent, you're very rushed with them, which is DEFINITELY a problem considering the equipment the base salvager gets, which is what is gonna be used to fight those since magnet, i'd suggest strong mob presence instead of turrets when possible honestly, because while the loot is good, definitely NOT worth the both risk and hassle of the turrets. Note: that doesnt apply to the xeno turret, that one does less DPS and bleed, so it could be fine?

[Bandirpvp]

Hey, salvager main here, LOVE the additions, my only problem is the turrets. considering this is gonna be on magnet not persistent, you're very rushed with them, which is DEFINITELY a problem considering the equipment the base salvager gets, which is what is gonna be used to fight those since magnet, i'd suggest strong mob presence instead of turrets when possible honestly, because while the loot is good, definitely NOT worth the both risk and hassle of the turrets. Note: that doesnt apply to the xeno turret, that one does less DPS and bleed, so it could be fine?

I have added the turrets in a way where theyre easily visible so that you won't have instances where someone rushes in and dies due to the turret being placed in a blind spot.
I was specifically adding them in a way where you should have enough time to deal with the turrets and collect the loot.

Also, rushing in blindly into a threat seems like a player mistake doesn't it? Theres several wrecks already that have turrets and i haven't seen these be a problem in particular.

[lilian-paddleston]

Turrets in open space means you can be ganked off of a grid, doesn’t it? Makes getting recovered very brutal. I agree, switch these to mobs.

[Bandirpvp]

Turrets in open space means you can be ganked off of a grid, doesn’t it? Makes getting recovered very brutal. I agree, switch these to mobs.

I added them all specifically indoors..?

[Boaz1111]

Note that this isn't a full review, just a small thing:
Your changelog shouldn't be 10 different entries. It should really just be

🆑

• add: Added 10 new salvage wrecks.

Or similar. Changelogs are used by players to know what new content to expect. The average player isn't gonna care about the name of the .yml file and such, so best to keep changelogs as simple as possible!

[KaiserMaus]

In one day..

[SlamBamActionman]

Hello! Salvage will be undergoing a major rework to its gameplay in the very near future, part of which involves an overhaul to how wrecks are spawned and generated via the Salvage magnet. This includes a stronger control over the contents and balance of wrecks, and what is mapped on them.

As such, I will be closing this PR for now. Once the rework has established its new spawn mechanics and balance requirements, feel free to revisit these wreck ideas in the new format.