Add test plans as a pull request requirement#643
Open
sowelipililimute wants to merge 1 commit into
Open
Conversation
VerinSenpai
suggested changes
May 1, 2026
| 3. Justifications that only explain what the pull request *does* or the *effects* that the changes have are not acceptable. | ||
| 4. Major content additions should align with the core design principles. Sufficiently large content additions might warrant a design document to detail the broader purpose of the changes and how they fit into the current game. | ||
| 3. The _Technical Details_ section should give a high-level overview of the changes. | ||
| 3. The _Test plan_ section should explain how to test the changes. |
There was a problem hiding this comment.
A wee bit inconsistent here with the capitalization. Test Plan would match the others
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See space-wizards/space-station-14#43839.
Given the large amount of refactors and corresponding bugs lately, I think we need to encourage pull request authors to step back and take a moment to think about how to verify their contribution works as intended.