Add additional Callgraph class inclusion filtering#1522
Open
aburghuber wants to merge 14 commits intosoot-oss:developfrom
Open
Add additional Callgraph class inclusion filtering#1522aburghuber wants to merge 14 commits intosoot-oss:developfrom
aburghuber wants to merge 14 commits intosoot-oss:developfrom
Conversation
This reverts commit a9eb74d.
Collaborator
|
mmh I like the includeCallTarget method. But I think a Call object as parameter or the addition of the invoking statement would be better, so the users could also consider the stmt in the check. i dont like the part about the base package. An application might not have one base package. We have also a similar approach with tagging a inputlocaction as Library. If it is tagged as Library then the call graph ignores it. So i would only partly accept this PR. However, thanks for improving SootUp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a nullable parameter called
basePackageNametoCallGraphAlgorithm#initializethat filters out all non-source classes from the graph (more accurately). Also addsAbstractCallGraphAlgorithm#includeCallToTargetfor even more additional filtering.The motivation behind this is that in Android projects often Android base API classes were included in the graph.
Checklist
Code style & guidelines
mvn com.spotify.fmt:fmt-maven-plugin:formatSelf-review
developReview