split OverridingJavaClassSource into two subclasses#1361
split OverridingJavaClassSource into two subclasses#1361SamarthBengle wants to merge 3 commits intosoot-oss:developfrom
Conversation
swissiety
left a comment
There was a problem hiding this comment.
please clean up the old/existing class - is that deletedMethods etc. newly introduced logic?
| @SuppressWarnings({"unchecked"}) | ||
| public class StandaloneJavaClassSource extends OverridingJavaClassSource { | ||
|
|
||
| private static final Position NO_POSITION = |
There was a problem hiding this comment.
an equivalent construct already exists in..Position?
There was a problem hiding this comment.
I didn't find anything suitable for it. So I used like this
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1361 +/- ##
=============================================
- Coverage 71.52% 70.25% -1.28%
Complexity 32 32
=============================================
Files 446 448 +2
Lines 18514 18849 +335
Branches 2964 2988 +24
=============================================
Hits 13243 13243
- Misses 4159 4494 +335
Partials 1112 1112
🚀 New features to boost your workflow:
|
|
please don't - I see the thought of doing it on-demand as well but we have to recalculate the collection(s) on every call while the collections are expected to be "small" so it just adds more logic |
b6f9d5d to
95e644a
Compare
No description provided.