Skip to content

split OverridingJavaClassSource into two subclasses#1361

Open
SamarthBengle wants to merge 3 commits intosoot-oss:developfrom
SamarthBengle:split-class-source
Open

split OverridingJavaClassSource into two subclasses#1361
SamarthBengle wants to merge 3 commits intosoot-oss:developfrom
SamarthBengle:split-class-source

Conversation

@SamarthBengle
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Collaborator

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please clean up the old/existing class - is that deletedMethods etc. newly introduced logic?

@SuppressWarnings({"unchecked"})
public class StandaloneJavaClassSource extends OverridingJavaClassSource {

private static final Position NO_POSITION =
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an equivalent construct already exists in..Position?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find anything suitable for it. So I used like this

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 0% with 335 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.25%. Comparing base (609abf8) to head (2c47939).
⚠️ Report is 215 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1361      +/-   ##
=============================================
- Coverage      71.52%   70.25%   -1.28%     
  Complexity        32       32              
=============================================
  Files            446      448       +2     
  Lines          18514    18849     +335     
  Branches        2964     2988      +24     
=============================================
  Hits           13243    13243              
- Misses          4159     4494     +335     
  Partials        1112     1112              
Components Coverage Δ
core 64.84% <ø> (ø)
java.core 60.31% <0.00%> (-12.19%) ⬇️
java.bytecode.frontend 79.68% <ø> (ø)
jimple.frontend 74.25% <ø> (ø)
apk.frontend 73.26% <ø> (ø)
interceptors 77.17% <ø> (ø)
callgraph 84.83% <ø> (ø)
codepropertygraph 75.12% <ø> (ø)
analysis.intraprocedural 66.24% <ø> (ø)
analysis.interprocedural 67.66% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SamarthBengle
Copy link
Copy Markdown
Author

please clean up the old/existing class - is that deletedMethods etc. newly introduced logic?
Yes, this is new. I added it to avoid copying entire collections when deleting, it just marks what to hide instead

@swissiety
Copy link
Copy Markdown
Collaborator

please clean up the old/existing class - is that deletedMethods etc. newly introduced logic?
Yes, this is new. I added it to avoid copying entire collections when deleting, it just marks what to hide instead

please don't - I see the thought of doing it on-demand as well but we have to recalculate the collection(s) on every call while the collections are expected to be "small" so it just adds more logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants