[layer1] CDB Commands with Advertised MaxDuration#2343
Open
pnakka28 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Pavan Kalyan Nakka <pnakka@microsoft.com>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
prgeor
reviewed
May 20, 2026
prgeor
reviewed
May 20, 2026
|
|
||
| The following table lists all CDB commands involved in the firmware upgrade process along with proposed timeout behavior: | ||
|
|
||
| #### Table 3: Upgrade Workflow CDB Commands |
|
|
||
| ### Functional Requirements | ||
|
|
||
| 1. For CDB commands where the CMIS defines a MaxDuration field, use the module advertised value as the command timeout. |
Contributor
There was a problem hiding this comment.
Should we introduce some tolerance other than the "MaxDuration" value?
| 1. **Parse MaxDuration in `initFwHandler()`** — Extend the existing CDB 0041h response parsing to extract MaxDuration fields (bytes 144–153), read the M multiplier from bit 137.3, multiply the U16 values by M, and store the resulting ms values as instance attributes. | ||
|
|
||
| 2. **Pass timeouts to `send_cmd()`** — Update the following methods to pass their respective MaxDuration value: | ||
| - `start_fw_download()` -> `timeout_start` |
Contributor
There was a problem hiding this comment.
Again, I assume we need to allow some tolerance other than the MaxDuration. start_fw_download does not mean that module has received the CDB command. There are latency from sonic to module, and there are latency if I2C is busy.
Author
There was a problem hiding this comment.
@Junchao-Mellanox Yes, we need some tolerance. I updated the doc to reflect that.
Signed-off-by: Pavan Kalyan Nakka <pnakka@microsoft.com>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Junchao-Mellanox
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR document proposes to use module advertised MaxDuration timeouts for CDB firmware commands according to the CMIS spec. The current CDB firmware upgrade path applies a fixed timeout to all commands. The CMIS spec defines MaxDuration fields for supported CDB commands that advertise how much time a module actually needs to execute each command.
Motivation
What this PR covers
sonic-platform-common.MSFT ADO - 38035182