[HLD] Add handling of role programming and bulk sync failures in HA state machine.#2336
Open
BYGX-wcr wants to merge 2 commits into
Open
[HLD] Add handling of role programming and bulk sync failures in HA state machine.#2336BYGX-wcr wants to merge 2 commits into
BYGX-wcr wants to merge 2 commits into
Conversation
…chine. Signed-off-by: BYGX-wcr <wcr@live.cn>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
r12f
previously approved these changes
May 15, 2026
| | DASH_HA_SCOPE_STATE | | | State of each HA scope. | | ||
| | | \<HA_SCOPE_ID\> | | HA scope ID. It can be the HA set ID or ENI ID, depending on the which HA mode is used. | | ||
| | | | last_updated_time | The last update time of this state in milliseconds. | | ||
| | | | last_update_ec | The error code of last update. 0 means no error. Non-zero values indicate different errors(Check the table below). | |
Contributor
There was a problem hiding this comment.
change ec to err / error / errorcode
| The current list of error code is defined as follows: | ||
| | Values | Error | | ||
| | --- | --- | | ||
| | 1 | Role activation failed | |
Contributor
There was a problem hiding this comment.
maybe we can follow sai status
…ode for the semantics Signed-off-by: BYGX-wcr <wcr@live.cn>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
vivekrnv
approved these changes
May 18, 2026
zjswhhh
changed the title
BYGX-wcr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we didn't define how to handle bulk sync failures and role activation failures.
Now, I define it as follows:
Besides, I also define a new field in DASH_HA_SCOPE_STATE to give target audience a more direct way to know failures from DPUs.
Related Code PR:
sonic-net/sonic-dash-ha#165