[orchagent] HLD: Redesign Orchagent Route Programming#2328
Open
venkit-nexthop wants to merge 1 commit into
Open
[orchagent] HLD: Redesign Orchagent Route Programming#2328venkit-nexthop wants to merge 1 commit into
venkit-nexthop wants to merge 1 commit into
Conversation
Add a high-level design document covering the orchagent route programming redesign. The redesign eliminates non-coalescing intermediate queues by updating m_toSync directly from mqPollThread, splits drain() into three independently schedulable stages (toBulkTask, flushTask, responseHandlingTask) with yield/resume semantics and bounded time quanta, and makes the route state publish asynchronous. Per-task instrumentation in orchdaemon and corresponding show/clear CLIs are also covered. Tracked under sonic-net/sonic-buildimage#27098. Signed-off-by: Venkit Kasiviswanathan <venkit@nexthop.ai>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doc/orchagent/describing a redesign of the orchagent route programming hot path.m_toSyncdirectly frommqPollThread, splitsdrain()into three independently schedulable stages (toBulkTask,flushTask,responseHandlingTask) with yield/resume semantics and bounded time quanta, and makes the route state publish asynchronous.show orchagent tasks/sonic-clear orchagent tasksinstrumentation.doc/orchagent/images/orchagent_route_redesign/(no inline base64).Why
Tracked under sonic-net/sonic-buildimage#27098: the current serial
pops()/addToSync()/drain()flow in the orchagent main thread lets ZMQ buffers and intermediate non-coalescing queues back up under churn and starves other orch agents of CPU.Test plan
images/orchagent_route_redesign/*.pnglinks.