Skip to content

fix: surface detailed simulation errors including InsufficientFundsFo… #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sushil-19 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: surface detailed simulation errors including InsufficientFundsFo… #951

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c881887
fix: surface detailed simulation errors including InsufficientFundsFo…
Sushil-19 Apr 16, 2026
633f87b
Update app/features/instruction-simulation/model/use-simulation.ts
Sushil-19 Apr 16, 2026
7fea9b4
Update app/features/instruction-simulation/model/use-simulation.ts
Sushil-19 Apr 16, 2026
7dc1ae5
fix: prioritize structured error before log scanning
Sushil-19 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions app/features/instruction-simulation/model/use-simulation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,30 @@ import { getMintDecimals, isTokenProgramBase58 } from '../lib/tokenAccountParsin
import type { SolBalanceChange } from '../lib/types';
import { useEpochInfo } from './use-epoch-info';

function parseSimulationError(err: object | string | null, logs?: string[]): string {

@rogaldh rogaldh May 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, but the current approach looks to me like an ad hoc solution.
I'd prefer to see a generalised approach to adopt @solana/errors, for example. Tests are also always welcome

if (!err) return '';

if (typeof err === 'string') {
if (err.includes('InsufficientFundsForFee')) {
return 'Insufficient funds for transaction fee';
}
return err;
}

if (typeof err === 'object') {
if ('InsufficientFundsForFee' in err) {
return 'Insufficient funds for transaction fee';
}
return JSON.stringify(err);
}

if (logs?.some(l => l.includes('InsufficientFundsForFee'))) {
return 'Insufficient funds for transaction fee';
}

return 'Transaction failed';
}

export function useSimulation(
message: VersionedMessage,
accountBalances?: {
Expand Down Expand Up @@ -223,7 +247,6 @@ export function useSimulation(

if (resp.value.logs.length === 0 && typeof resp.value.err === 'string') {
setLogs(null);
setError(resp.value.err);
} else {
// Prettify logs
setLogs(parseProgramLogs(resp.value.logs, resp.value.err, cluster));
Expand All @@ -234,7 +257,7 @@ export function useSimulation(
}
// If the response has an error, the logs will say what it it, so no need to parse here.
if (resp.value.err) {
setError('TransactionError');
setError(parseSimulationError(resp.value.err, resp.value.logs ?? undefined));
}
} catch (err) {
Logger.error(err);
Expand Down