FIX: Stable degeneracy#801
Closed
nkeim wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
I should note that besides fixing the issues with GitHub actions, it's important to evaluate the effect of this PR on performance. It's easy to see how using a custom hash could dramatically slow down linking. I would love for someone to check this with their own data! |
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #776 in most if not all cases, by making the order of a
setofPointobjects non-random.While the order of a set is never guaranteed, it is based on the objects'
hashvalues. Starting with Python 3.3 these hashes were randomized as a security measure. This issue was causing repeated linking runs to resolve degenerate cases randomly, even within the same session. This PR makes Python use the Point'suuidattribute (basically, its serial number) instead.This PR adds tests to make sure that degenerate linking cases (with and without memory) always resolve the same way within the same session. It does not ensure that results are consistent across linkers or across sessions. (It turns out this requires a change to the linking algorithm itself, so it will be a separate PR.)