fix: relax ruamel.yaml constraint to support Airflow 3.2+ environments#2763
Open
cschanhniem wants to merge 1 commit into
Open
fix: relax ruamel.yaml constraint to support Airflow 3.2+ environments#2763cschanhniem wants to merge 1 commit into
cschanhniem wants to merge 1 commit into
Conversation
soda-core pins ruamel.yaml to <0.18.0, but Apache Airflow 3.2.1 constraints require ruamel.yaml==0.19.1. This prevents running Soda data quality checks inside Airflow environments using official constraints. The core APIs used by soda-core (YAML(), CommentedMap, CommentedSeq, MarkedYAMLError, .lc line/col tracking) are stable across ruamel.yaml 0.17.x through 0.19.x. Expanding the upper bound to <0.20.0 removes the blocker for Airflow users without changing the minimum supported version. Refs: sodadata#2746 Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
soda-core pins
ruamel.yamlto<0.18.0, but Apache Airflow 3.2.1 constraints requireruamel.yaml==0.19.1. This makessoda-core(and all connector packages depending on it) uninstallable in Airflow 3.2+ environments using official constraint files.Fixes #2746
Changes
<0.18.0to<0.20.0Why this is safe
The core APIs used by soda-core —
YAML(),CommentedMap,CommentedSeq,MarkedYAMLError,.lcline/column tracking — are stable across ruamel.yaml 0.17.x through 0.19.x.Current usage across the codebase:
soda-core/src/soda_core/common/yaml.py:YAML(),CommentedMap,CommentedSeq,MarkedYAMLErrorsoda-core/src/soda_core/contracts/impl/contract_verification_impl.py:from ruamel.yaml import YAMLNone of these APIs have changed in a breaking way between 0.17 and 0.19.
Test plan
Closes #2746