Skip to content

feat: use semantic colors for heatmap in event probability columns#371

Merged
johanneskoester merged 2 commits intomasterfrom
feat/prob-coloring
Mar 26, 2025
Merged

feat: use semantic colors for heatmap in event probability columns#371
johanneskoester merged 2 commits intomasterfrom
feat/prob-coloring

Conversation

@johanneskoester
Copy link
Copy Markdown
Contributor

@johanneskoester johanneskoester commented Mar 26, 2025

Summary by CodeRabbit

  • New Features
    • Enhanced heatmap visualization for probability values. The update now distinguishes between valid data and cases identified as anomalies or absences by applying distinct color schemes. This improvement ensures clearer and more informative heatmap displays for end-users.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 26, 2025

Walkthrough

This change updates the YAML configuration for plotting heatmaps. The regex matching logic is modified to separate probability values. The original pattern has been replaced with one that excludes the terms "artifact" and "absent", and a new pattern is introduced to specifically target these terms. The two branches now apply different color ranges and scales based on the matched value.

Changes

File Change Summary
workflow/.../variant-calls-template.datavzrd.yaml Replaced "regex('prob: .+')" with `"regex('prob: (?!artifact

Sequence Diagram(s)

sequenceDiagram
    participant Data as Probability Data
    participant Regex as Regex Filter
    participant Plot as Heatmap Plotter

    Data->>Regex: Evaluate input "prob: <value>"
    alt Value matches "artifact" or "absent"
        Regex-->>Plot: Apply regex("prob: (artifact|absent)")
        Plot->>Plot: Set color scale white to #d4322c
    else Other value
        Regex-->>Plot: Apply regex("prob: (?!artifact|absent)")
        Plot->>Plot: Set color scale white to #1f77b4
    end
Loading

Poem

I’m a bunny on the run,
Regex tricks now clearly done,
Excluding “absent” with a hop so neat,
“Artifact” marked in a rhythmic beat,
My configuration hops with flair,
Colors dancing in the air!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a95549 and ad3fa48.

📒 Files selected for processing (1)
  • workflow/resources/datavzrd/variant-calls-template.datavzrd.yaml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: test sra download
  • GitHub Check: test primers
  • GitHub Check: test no candidate filtering
  • GitHub Check: test target regions, multiple BEDs
  • GitHub Check: test target regions
  • GitHub Check: test testcase generation
  • GitHub Check: test local input
🔇 Additional comments (2)
workflow/resources/datavzrd/variant-calls-template.datavzrd.yaml (2)

262-277: Semantic Color Implementation for Probability Columns (Coding Variants)
The updated regex patterns now separate standard probability values from those tagged as "artifact" or "absent." The negative lookahead in "regex('prob: (?!artifact|absent)')" correctly excludes the unwanted values while the dedicated pattern "regex('prob: (artifact|absent)')" applies a distinct color range from white to "#d4322c." This clear separation should help in the visual interpretation of the heatmaps.
Please verify that the regex syntax and YAML quoting work as expected in your templating engine since regex expressions in configuration files can be sensitive to escaping nuances.


444-459: Consistent Semantic Coloring for Noncoding Variants
This block applies the same semantic color logic for probability fields in the noncoding dataset. The identical use of "regex('prob: (?!artifact|absent)')" and "regex('prob: (artifact|absent)')" ensures consistency across different datasets. As before, double-check that the regex patterns function correctly in the YAML context, and consider adding tests with sample probability strings (including those with "artifact" and "absent") to validate the expected behavior.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@johanneskoester johanneskoester merged commit d966dc3 into master Mar 26, 2025
11 checks passed
@johanneskoester johanneskoester deleted the feat/prob-coloring branch March 26, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant