feat(compact): add import arrow icon for grid - #811
Open
llaforest wants to merge 1 commit into
Open
Conversation
- Already an image for grid export - 0W standby uses a transmission tower with no arrow - Added an import image with incoming arrow when importing from grid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The compact card grid icon had no directional arrow for import state. Only export had a dedicated icon (
gridExportCompact), while both standby (0W) and import (>0W) shared the same plain tower icon (gridOn).This PR adds a
gridImportCompacticon (the directional mirror ofgridExportCompact) and splits the condition into three distinct visual states:power > 0→ tower with right-pointing arrow (importing from grid)power = 0→ plain tower, no arrow (standby)power < 0→ tower with left-pointing arrow (exporting to grid)Changes
src/helpers/icons.ts: addedgridImportCompactSVG pathsrc/components/compact/grid/grid-elements.ts: splittotalGridPower >= 0condition into=== 0(standby) and> 0(import)Test plan
import_iconconfig still works (hides built-in icon)