Fire vttablet_restore_done hook from RestoreFromBackup RPC path#816
Merged
tanjinx merged 1 commit intoslack-19.0from Mar 9, 2026
Merged
Fire vttablet_restore_done hook from RestoreFromBackup RPC path#816tanjinx merged 1 commit intoslack-19.0from
tanjinx merged 1 commit intoslack-19.0from
Conversation
The vttablet_restore_done hook was only invoked from the RestoreData (startup) path, but not from the RestoreFromBackup RPC handler. This meant restores triggered via vtctldclient never fired the hook. Signed-off-by: Stas Maksimov <smaksimov@slack-corp.com> Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
tanjinx
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
backport vitessio#19592
Fire
vttablet_restore_donehook fromRestoreFromBackupRPC path.The hook was only invoked from the
RestoreDatastartup path, but not from theRestoreFromBackupRPC handler. This meant restorestriggered via
vtctldclient RestoreFromBackupnever fired the hook.Follow-up to #812 which backported the backup engine env var to v19.
Changes
Add
invokeRestoreDoneHookcall toRestoreFromBackupinrpc_backup.go, matching the pattern already used inRestoreData.Test plan
vtctldclient RestoreFromBackupand verify thevttablet_restore_donehook is executed (visible invttablet logs)
TM_RESTORE_DATA_START_TS,TM_RESTORE_DATA_STOP_TS,TM_RESTORE_DATA_DURATION,TM_RESTORE_DATA_BACKUP_ENGINERelated Issue(s)
Checklist
Deployment Notes
AI Disclosure