Skip to content

add more metrics buckets#639

Closed
rvrangel wants to merge 4 commits intoslack-19.0from
v19-metrics-buckets
Closed

add more metrics buckets#639
rvrangel wants to merge 4 commits intoslack-19.0from
v19-metrics-buckets

Conversation

@rvrangel
Copy link
Copy Markdown

Description

This adds 200ms, 300ms, 400ms buckets for additional precision on histograms.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
@github-actions github-actions Bot added this to the v19.0.7 milestone Apr 16, 2025
@rvrangel rvrangel marked this pull request as ready for review April 16, 2025 12:12
@rvrangel rvrangel requested a review from a team as a code owner April 16, 2025 12:12
@timvaillancourt
Copy link
Copy Markdown

@rvrangel / @tanjinx is the plan to run this as a branch, or do we want to commit to this being in v19?

@rvrangel
Copy link
Copy Markdown
Author

I think this should be a branch for now. if we deploy this to a canary and we notice better accuracy in the 100~500ms range, then we could commit it to v19 (or possible propose upstream a way of defining the buckets via a flag)

@github-actions
Copy link
Copy Markdown

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions Bot added the Stale label May 19, 2025
@github-actions
Copy link
Copy Markdown

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions Bot closed this May 26, 2025
@timvaillancourt timvaillancourt deleted the v19-metrics-buckets branch August 5, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants