Updating AndroidPredictiveBackNavDecorator#2009
Merged
Conversation
- Fix zindexing issues - Update Shared element transition style predictive back - Add code for the full screen surfaces predictive back
Collaborator
|
My understanding is the right side one is what the spec is supposed to be and that anything in the framework not doing this is just lagging behind the spec. Let me ask around |
ZacSweers
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Was reviewing the predictive back guide and there are two distinct animations. One for a full surface cross-fade and another for a shared element style. Current implementation is closer to the shared element, but did both to try them out (see demos).
Not sure if we want both or how we'd pick which one to use at runtime 🤔Going with the shared element approach.Also ended up fix a z-indexing issue which should fix #2002
Demos
predictive-fullsurface.mp4
predictive-shared.mp4