This repository was archived by the owner on Nov 3, 2025. It is now read-only.
Add configurable background interaction mode to allow forwarding touches to presenting view#220
Closed
rahulVermaSimpplr wants to merge 4 commits intoslackhq:masterfrom
Closed
Add configurable background interaction mode to allow forwarding touches to presenting view#220rahulVermaSimpplr wants to merge 4 commits intoslackhq:masterfrom
rahulVermaSimpplr wants to merge 4 commits intoslackhq:masterfrom
Conversation
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Ilya Kharlamov <k***@r***.ru>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
|
Thanks for the contribution! Before we can merge this, we need @ilia3546 to sign the Salesforce Inc. Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates changes from slackhq/PanModal#115 into this fork, introducing a backgroundInteraction property on PanModalPresentable and the PanModalBackgroundInteraction enum.
With these changes, developers can control how touches on the dimmed background are handled:
.dismiss — dismiss the modal (existing behavior)
.forward — forward the touch events (including taps, scrolls, and drags) to the presenting view’s hierarchy
.none — swallow the touch without action
This enables scenarios where the bottom sheet remains interactive and the presenting view can also receive gestures on the uncovered background area (e.g., scrolling lists, interacting with buttons).
No breaking changes — existing behavior remains the default unless backgroundInteraction is overridden.