This repository was archived by the owner on Nov 3, 2025. It is now read-only.
Allow opting out of appearance transition callbacks on presenting view controller#145
Open
nolanw wants to merge 1 commit intoslackhq:masterfrom
Open
Allow opting out of appearance transition callbacks on presenting view controller#145nolanw wants to merge 1 commit intoslackhq:masterfrom
nolanw wants to merge 1 commit intoslackhq:masterfrom
Conversation
|
|
Author
|
(I would prefer not to sign a CLA, as that would allow y'all to relicense these changes under a proprietary license. In lieu, I would be happy to submit a Developer Certificate of Origin or similar.) |
134d117 to
9274d55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
PanModalPresentables to opt out of having appearance transition callbacks (viewWillAppearetc.) called on the presenting view controller. (#47)Requirements (place an
xin each[ ])Notes
testPresentableYValuesfails for me locally, but it wasn't relevant to this PR :)In #47, there's a request for a reason to avoid these calls. In our case, we're showing the modal with a blurred background, and we wanted the presenting view controller's content to continue updating (we stop updating in viewDidDisappear). I went with a property on
PanModalPresentableto avoid breaking existing library users, who may rely on the current behavior.Thank you for sharing PanModal!