Skip to content
This repository was archived by the owner on Nov 3, 2025. It is now read-only.

Allow opting out of appearance transition callbacks on presenting view controller#145

Open
nolanw wants to merge 1 commit intoslackhq:masterfrom
happybits:optional-appearance-transition-calls
Open

Allow opting out of appearance transition callbacks on presenting view controller#145
nolanw wants to merge 1 commit intoslackhq:masterfrom
happybits:optional-appearance-transition-calls

Conversation

@nolanw
Copy link
Copy Markdown

@nolanw nolanw commented Apr 12, 2021

Summary

Allow PanModalPresentables to opt out of having appearance transition callbacks (viewWillAppear etc.) called on the presenting view controller. (#47)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've written tests to cover the new code and functionality included in this PR.

Notes

testPresentableYValues fails for me locally, but it wasn't relevant to this PR :)

In #47, there's a request for a reason to avoid these calls. In our case, we're showing the modal with a blurred background, and we wanted the presenting view controller's content to continue updating (we stop updating in viewDidDisappear). I went with a property on PanModalPresentable to avoid breaking existing library users, who may rely on the current behavior.

Thank you for sharing PanModal!

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nolanw
Copy link
Copy Markdown
Author

nolanw commented Apr 12, 2021

(I would prefer not to sign a CLA, as that would allow y'all to relicense these changes under a proprietary license. In lieu, I would be happy to submit a Developer Certificate of Origin or similar.)

@nolanw nolanw force-pushed the optional-appearance-transition-calls branch from 134d117 to 9274d55 Compare April 14, 2021 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants