fix(forms): validate Helm release name, ignored namespace, and port-forward port

[eliran-ops]

Summary

Adds shared input validation to three Radar forms that were previously accepting bad input silently. Linear: SKY-821.

Bugs fixed:

• 24 — Helm install accepted release names like `Invalid Name With Spaces!` and proceeded to step 2; the install only failed server-side.
• 25 — Audit Settings → Add Ignored Namespace accepted `INVALID_NAME!@#` with no validation.
• 26 — Port-Forward dialog silently swallowed `0`, `-1`, `70000` and similar in the local-port input.
• 27 — No rejection feedback at all in the port-forward dialog.
• 63 — Audit Settings 'Save' button stayed enabled when the only pending edit was an invalid namespace string.

Approach

New module `packages/k8s-ui/src/utils/validators.ts` with pure validators:

Function	Used for	Rule
`validateRFC1123Label`	k8s namespace / pod / service names	`a-z0-9?`, ≤63 chars
`validateRFC1123Subdomain`	dotted DNS subdomains	labels joined by '.', ≤253 chars
`validateHelmReleaseName`	Helm release names	RFC 1123 subdomain + Helm's 53-char cap
`validatePort`	TCP/UDP ports as text	strict integer in [1, 65535], no decimals/scientific/+/whitespace

Each returns a discriminated-union `ValidationResult` so callers can pattern-match without re-parsing. 29 unit tests pin the canonical rules and cover every reported fixture verbatim plus the relevant boundaries.

Wiring

• `InstallWizard.tsx` — memoized validations on release name + namespace; red border + inline red error on invalid; `canProceedFromInfo` requires both validations to pass.
• `AuditSettingsDialog.tsx` — validates the staged input before `addNamespace`; Add (+) disabled on invalid OR duplicate input; Save disabled while there's pending invalid input with a tooltip explaining why.
• `PortForwardButton.tsx` — tracks raw input separately from validated port so the user always sees what they typed (no silent swallow); red border + inline error on rejection; falls back to the original remote port so the kubectl command is always runnable.

Test plan

• `cd packages/k8s-ui && npm test` — 91 passed (29 new)
• `cd web && npm run tsc` — clean
• `cd web && npm run build` — clean

Made with Cursor

---

Note

Medium Risk
Medium risk because it changes client-side validation gates for Helm installs and audit settings; overly-strict rules could block previously accepted (but possibly valid) user input and alter submission behavior.

Overview
Introduces a new shared utils/validators module (with unit tests) that codifies RFC1123 label/subdomain rules, Helm release-name constraints, and strict port parsing.

Updates the Helm InstallWizard to validate release name and namespace before advancing/installing, surface inline errors, and submit trimmed values to the API.

Updates AuditSettingsDialog to validate/deny invalid or duplicate ignored-namespace entries, show inline error text, and disable Save while there’s pending invalid input.

Updates the port-forward kubectl dialog to validate the local port as raw text (no silent truncation), show error feedback, and fall back to the original port when invalid.

^{Reviewed by Cursor Bugbot for commit 7426ab3. Bugbot is set up for automated code reviews on this repo. Configure here.}

[eliran-ops]

@nadaverell @hisco — ready for review. Cursor bugbot found 4 issues across the helm-name validators: trim mismatch in InstallWizard, trailing period in error string, missing per-label 63-char check, and validator allowing dots in release names. First three were addressed earlier (c8e583a, a668623). Just pushed e9f2586 to fix the last one — validateHelmReleaseName now delegates to validateRFC1123Label so dots are rejected up front (Helm permits them, but generated resource names <release>-<chart>-<hash> must be valid DNS-1123 labels and K8s rejects the apply server-side). Added a regression test. Cursor Bugbot SUCCESS on current HEAD.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 7426ab3. Configure here.}

[cursor]

Port validator allows leading zeros despite documented contract

Low Severity

The validatePort docstring on line 140 explicitly states it accepts strings with "no leading zeros," but the regex /^\d+$/ permits inputs like "01", "007", or "0080". For example, validatePort("01") returns { valid: true, value: 1 } instead of rejecting it. The test suite also has no coverage for leading-zero inputs. Either the regex needs tightening (e.g., /^([1-9]\d*|0)$/ and then range-reject 0) or the docstring needs correction, since right now callers cannot rely on the documented contract.

 

^{Reviewed by Cursor Bugbot for commit 7426ab3. Configure here.}