feat(ui): close resource and Helm drawers by clicking outside#361
Open
SaviorVirus wants to merge 1 commit intoskyhook-io:mainfrom
Open
feat(ui): close resource and Helm drawers by clicking outside#361SaviorVirus wants to merge 1 commit intoskyhook-io:mainfrom
SaviorVirus wants to merge 1 commit intoskyhook-io:mainfrom
Conversation
Add a transparent backdrop overlay behind the resource detail drawer and Helm release drawer so users can dismiss them by clicking any empty area, instead of having to click the same row again. Made-with: Cursor
nadaverell
reviewed
Mar 28, 2026
Contributor
There was a problem hiding this comment.
Thanks for the PR!
I think this makes sense on the topology view where clicking empty space feels like it should dismiss the drawer, but not so much on the resource and helm views. There it was intentional that users can click through different rows to switch the drawer content.
In those, we have 3 close mechanisms - X button, Escape, clicking the same row.
If we want click-outside-to-close specifically for the topology graph, that could be handled at the graph canvas level rather than with a global backdrop.
Contributor
|
Hey @SaviorVirus, friendly ping — any thoughts on scoping click-outside to the topology canvas? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a transparent backdrop overlay behind the resource detail drawer and Helm release drawer so users can dismiss them by clicking any empty area, instead of having to click the same row again.
Made-with: Cursor
Description
Currently, to close the resource detail drawer or Helm release drawer, users had to click the same row that opened it (or the X button). This PR adds a transparent backdrop overlay behind both drawers so clicking anywhere on the empty area to the left dismisses them — a more intuitive UX pattern.
Changes:
packages/k8s-ui/src/components/workload/ResourceDetailDrawer.tsx— backdrop is hidden when the drawer is expanded to full-screen WorkloadView to prevent accidental dismissalweb/src/components/helm/HelmReleaseDrawer.tsx— same backdrop addedType of change
How has this been tested?
Checklist
Related issues
N/A