Implements some simple LabeledContent showcases#98
Merged
Conversation
|
Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @chbeer on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file |
marcprux
requested changes
May 8, 2026
Member
marcprux
left a comment
marcprux
left a comment
There was a problem hiding this comment.
Looks good! Just a couple minor changes needed.
|
|
||
| struct LabeledContentPlayground: View { | ||
| #if os(macOS) | ||
| let placement: ToolbarItemPlacement = .automatic |
Member
There was a problem hiding this comment.
It doesn't look like placement is used, so you can remove this whole block.
| ScrollView { | ||
| VStack(spacing: 16) { | ||
| LabeledContent("Label", value: "Value") | ||
| // LabeledContent("Label", value: 12, format: IntegerFormatStyle.number) |
Member
There was a problem hiding this comment.
Maybe add a comment that this is unsupported currently, but would make for a good future improvement.
marcprux
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Skip Pull Request Checklist:
swift test