Open
Conversation
mhsdesign
requested changes
Sep 15, 2025
Collaborator
mhsdesign
left a comment
There was a problem hiding this comment.
Hi thank you:)
this is a regression from #28 - which complained that the space being encoded to + will not show up correct in the mail app.
I suggest to use the following snippet so spaces are correctly encoded as %20 via encodeURIComponent
convertModelToLink: (email:MailToLinkModel) => {
const query = Object.entries({
subject: email.subject,
cc: email.cc,
bcc: email.bcc,
body: email.body,
})
.filter(([_key, value]) => value != null)
.map(([key, value]) => `${key}=${encodeURIComponent(value as string)}`)
.join('&');
const href = `mailto:${email.recipient}${query ? `?${query}` : ''}`;
return {href};
},btw in the version which will be part of Neos 9.1 i already did this
mhsdesign
added a commit
to neos/neos-ui
that referenced
this pull request
Sep 16, 2025
Replaces sitegeist/Sitegeist.Archaeopteryx#94 Refixes sitegeist/Sitegeist.Archaeopteryx#28 - which complained that the space being encoded to + will not show up correct in the mail app. Now spaces are correctly encoded as %20 via encodeURIComponent
mhsdesign
added a commit
to neos/neos-ui
that referenced
this pull request
Oct 30, 2025
Replaces sitegeist/Sitegeist.Archaeopteryx#94 Refixes sitegeist/Sitegeist.Archaeopteryx#28 - which complained that the space being encoded to + will not show up correct in the mail app. Now spaces are correctly encoded as %20 via encodeURIComponent
mhsdesign
added a commit
to neos/neos-ui
that referenced
this pull request
Nov 11, 2025
Replaces sitegeist/Sitegeist.Archaeopteryx#94 Refixes sitegeist/Sitegeist.Archaeopteryx#28 - which complained that the space being encoded to + will not show up correct in the mail app. Now spaces are correctly encoded as %20 via encodeURIComponent
mhsdesign
added a commit
to neos/neos-ui
that referenced
this pull request
Nov 16, 2025
Replaces sitegeist/Sitegeist.Archaeopteryx#94 Refixes sitegeist/Sitegeist.Archaeopteryx#28 - which complained that the space being encoded to + will not show up correct in the mail app. Now spaces are correctly encoded as %20 via encodeURIComponent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes care of #77