fix: replace worker pool with semaphore to prevent deadlock in recurs…#1361
Open
jbuhagiar88 wants to merge 1 commit into
Open
fix: replace worker pool with semaphore to prevent deadlock in recurs…#1361jbuhagiar88 wants to merge 1 commit into
jbuhagiar88 wants to merge 1 commit into
Conversation
…ive dir scan The previous fixed-size worker pool pattern caused deadlocks when recursive directory scanning submitted tasks faster than workers could consume them. The pool's task channel would block, causing all goroutines to stall. Changes: - worker.go: Replace Pool (fixed goroutines + task channel) with Semaphore (unlimited goroutines, N concurrent). Semaphore allows each submitted task to spawn its own goroutine immediately, avoiding channel backpressure. Pool type retained for backward compatibility; Stop() is now a no-op. - run.go: Buffer the gOut channel (10000) so folder scanning goroutines don't block waiting for the upload consumer. Removes go wrapper around pool.Submit() since Submit() now spawns its own goroutine internally. Tested against large library (100k+ files) — no deadlock observed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ive dir scan
The previous fixed-size worker pool pattern caused deadlocks when recursive directory scanning submitted tasks faster than workers could consume them. The pool's task channel would block, causing all goroutines to stall.
Changes:
Tested against large library (100k+ files) — no deadlock observed.