Fix panic on 386 and armhf#1334
Open
toddy15 wants to merge 1 commit into
Open
Conversation
On 386 and armhf, the code panics with "unaligned 64-bit atomic operation". The documentation on https://pkg.go.dev/sync/atomic#AddInt64 has this warning: "Consider using the more ergonomic and less error-prone Int64.Add instead (particularly if you target 32-bit platforms; see the bugs section)." The type atomic.Int64 is automatically aligned. See https://pkg.go.dev/sync/atomic#pkg-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for creating immich-go! I've just built a Debian package for this program and noticed build failures on 386 and armhf. This is a fix I've come up with.
On 386 and armhf, the code panics with "unaligned 64-bit atomic operation". The documentation on https://pkg.go.dev/sync/atomic#AddInt64 has this warning:
"Consider using the more ergonomic and less error-prone Int64.Add instead (particularly if you target 32-bit platforms; see the bugs section)."
The type atomic.Int64 is automatically aligned.
See https://pkg.go.dev/sync/atomic#pkg-notes