Improved pipeline and performance on ARM with low mem#1325
Open
piotrasd wants to merge 1 commit into
Open
Conversation
…ter completes. The root cause is that file discovery blocks waiting for album metadata to finish loading from the server. This patch buffers the discovery output channel so both stages run independently, parallelises album detail fetching across the worker pool, and adds a visible [Fetching album details...] progress indicator so the process no longer appears frozen. Four targeted changes to reduce memory pressure and I/O overhead on 1 GB devices: sets GOMEMLIMIT to 800 MB so the Go garbage collector batches work instead of triggering on every heap growth; increases the SHA1 read buffer from 32 KB to 4 MB with a sync.Pool to cut SD card syscalls by ~99% per file; buffers the worker pool task channel so the main goroutine stays ahead of workers without stalling; and reduces the HTTP connection pool from 100 to 16 connections, saving ~700 KB of idle goroutine stacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a hang that occurs on ARM devices after the "Assets found" counter completes. The root cause is that file discovery blocks waiting for album metadata to finish loading from the server. This patch buffers the discovery output channel so both stages run independently, parallelises album detail fetching across the worker pool, and adds a visible [Fetching album details...] progress indicator so the process no longer appears frozen.
Four targeted changes to reduce memory pressure and I/O overhead on 1 GB devices: sets GOMEMLIMIT to 800 MB so the Go garbage collector batches work instead of triggering on every heap growth; increases the SHA1 read buffer from 32 KB to 4 MB with a sync.Pool to cut SD card syscalls by ~99% per file; buffers the worker pool task channel so the main goroutine stays ahead of workers without stalling; and reduces the HTTP connection pool from 100 to 16 connections, saving ~700 KB of idle goroutine stacks.